Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make eos_vlan idempotent #34443

Merged
merged 1 commit into from
Jan 4, 2018
Merged

make eos_vlan idempotent #34443

merged 1 commit into from
Jan 4, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Jan 4, 2018 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #33711
The module misses the condition if name is None, hence converts it into string 'None' which makes vlan name 'None' and causes idempotence failure.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/eos/eos_vlan

ANSIBLE VERSION
2.5

@trishnaguha
make eos_vlan idempotent
8c52088 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha added the networking Network category label Jan 4, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 4, 2018

cc @privateip @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 4, 2018
ganeshrn
ganeshrn approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trishnaguha trishnaguha merged commit 0f24199 into ansible:devel Jan 4, 2018
@trishnaguha trishnaguha deleted the eos_vlan_idempotent branch January 4, 2018 12:42
@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List Jan 5, 2018
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Jan 5, 2018
@trishnaguha
make eos_vlan idempotent (ansible#34443)
7750c54 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 0f24199)
trishnaguha added a commit that referenced this pull request Jan 5, 2018
@trishnaguha
Make eos_vlan idempotent (#34503)
cf31e47 
* make eos_vlan idempotent (#34443)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 0f24199)

* Make eos_vlan idempotent CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha moved this from Nice to have to Done in 2.4.3 in 2.4.x Blocker List Jan 5, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aggregate on eos does not seem idempotent
3 participants
@trishnaguha @ansibot @ganeshrn