Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_cluster: Fix cluster cpu arch comparision #34446

Merged
merged 1 commit into from Jan 4, 2018
Merged

ovirt_cluster: Fix cluster cpu arch comparision #34446

merged 1 commit into from Jan 4, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

oVirt REST API don't return cpu/arch elelemnt in case it's not set, so we fail the update check. We can just ignore that comparsion in case it's not set, so it's resolve the issue.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_cluster

ANSIBLE VERSION
2.4
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 4, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 4, 2018
@machacekondra machacekondra force-pushed the ovirt_cluster_cpu_arch_compare_fix branch from c564b77 to 831a3a1 Compare January 4, 2018 11:38
@machacekondra
Copy link
Contributor Author

shipit

@machacekondra machacekondra mentioned this pull request Jan 4, 2018
Closed
mwperina
mwperina approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jan 4, 2018
@ansibot ansibot merged commit 2376d02 into ansible:devel Jan 4, 2018
gerrit-ovirt-org pushed a commit to oVirt/ovirt-hosted-engine-setup that referenced this pull request Feb 28, 2018
@tiraboschi
ansible: enable gluster at cluster level
2a66808 
Enable gluster at cluster level on
HC deployments before adding the first host.

Backport ovirt_cluster.py from ansible 2.5
to fix an issue (
ansible/ansible#34446
) still affecting ansible 2.5.

Change-Id: I93b7da8915a90306ed4b4807c42435321dcbe4f6
Bug-Url: https://bugzilla.redhat.com/1543486
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
gerrit-ovirt-org pushed a commit to oVirt/ovirt-hosted-engine-setup that referenced this pull request Feb 28, 2018
@tiraboschi
ansible: enable gluster at cluster level
4cec28d 
Enable gluster at cluster level on
HC deployments before adding the first host.

Backport ovirt_cluster.py from ansible 2.5
to fix an issue (
ansible/ansible#34446
) still affecting ansible 2.5.

Change-Id: I93b7da8915a90306ed4b4807c42435321dcbe4f6
Bug-Url: https://bugzilla.redhat.com/1543486
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
(cherry picked from commit 2a66808)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@mkrish004c mkrish004c mentioned this pull request Mar 15, 2018
Merged
@machacekondra machacekondra deleted the ovirt_cluster_cpu_arch_compare_fix branch August 15, 2018 10:43
@dagwieers dagwieers added the ovirt oVirt and RHV community label Feb 20, 2019
@dagwieers dagwieers removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 28, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@machacekondra @ansibot @mwperina @dagwieers