Don't use the Task object in the dictionary of results for include_role #34461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The short-circuiting of include_role in TaskExecutor was using the _task object in the result dictionary. This causes the playbook class to be serialized, which is something we no longer do due to speed/size problems with nested objects. Simply removing this should fix a lot of memory and speed problems with include_role.
|
!bot_skip |
ansibot
added
affects_2.5
|
Cherrypicked for 2.4.3rc3 |
|
This has been reverted from 2.4.3rc3 as it causes undesired behaviour. We're evaluating whether a fix that does not change behaviour can be added into 2.4.3 or if it will have to wait for 2.4.4. |
|
I was confused. The commit causing the new behaviour is in rc2 and is a blocker for the 2.4.3 release. I've re-cherry-picked this commit for the 2.4.3-rc3 release which will be next Wednesday, the 24th of January. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short-circuiting of include_role in TaskExecutor was using the _task object
in the result dictionary. This causes the playbook class to be serialized, which
is something we no longer do due to speed/size problems with nested objects.
Simply removing this should fix a lot of memory and speed problems with include_role.