Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with win_iis_website parameter types. Issue #34500 #34501

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Fixing issue with win_iis_website parameter types. Issue #34500 #34501

merged 3 commits into from
Jan 8, 2018

Conversation

jn-bedag
Copy link
Contributor

@jn-bedag jn-bedag commented Jan 5, 2018

SUMMARY

Fixes #34500
There are two types of attributes. "String" and "Configuration Attribute". We need to get the real "value" based on the type.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_iis_website.ps1

ANSIBLE VERSION
ansible 2.4.2.0

Using $complex_args is not working (anymore?). We need to set $params directly.
There are two types of attributes. "String" and "Configuration Attribute". We need to get the real "value" based on the type.
@ansibot
Copy link
Contributor

ansibot commented Jan 5, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Jan 5, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jan 5, 2018
@jborean93 jborean93 merged commit 7f59f7d into ansible:devel Jan 8, 2018
jborean93 pushed a commit that referenced this pull request Jan 8, 2018
* remidate Windows debugging

Using $complex_args is not working (anymore?). We need to set $params directly.

* Fixing issue with win_iis_website parameter types

There are two types of attributes. "String" and "Configuration Attribute". We need to get the real "value" based on the type.

* Revert "remidate Windows debugging"

This reverts commit df75d3b.

(cherry picked from commit 7f59f7d)
@jborean93
Copy link
Contributor

Cherry-picked to stable-2.4 61ec5c0, will be available in the 2.4.3.0 release.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

win_iis_website always changed with parameter logExtFileFlags
4 participants