Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_become: another option to support become flags for runas #34551

Merged
merged 4 commits into from Jan 19, 2018
Merged

win_become: another option to support become flags for runas #34551

merged 4 commits into from Jan 19, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Less intrusive change than #33297, keeping open as one of the options to go for.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

become

ANSIBLE VERSION
2.5

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2018

cc @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 docs_pull_request needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Jan 7, 2018
@jborean93 jborean93 added windows Windows community and removed windows Windows community needs_triage Needs a first human triage before being processed. labels Jan 7, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 15, 2018
@nitzmahone nitzmahone mentioned this pull request Jan 19, 2018
Closed
dharmabumstead
dharmabumstead approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with some edits. Thanks @jborean93!

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 19, 2018
@jborean93
Copy link
Contributor Author

No worries, thanks for the review @dharmabumstead

@nitzmahone nitzmahone merged commit d0e6889 into ansible:devel Jan 19, 2018
@jborean93 jborean93 deleted the become-flags-win branch January 19, 2018 22:33
@ansibot ansibot added docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dharmabumstead dharmabumstead dharmabumstead approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @ansibot @dharmabumstead @nitzmahone