Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aci_aaa_user_certificate: Add a certificate to an AAA user #34602

Merged
merged 2 commits into from
Jan 10, 2018
Merged

aci_aaa_user_certificate: Add a certificate to an AAA user #34602

merged 2 commits into from
Jan 10, 2018

Conversation

dagwieers
Copy link
Contributor

SUMMARY

A new ACI module to add a X.509 certificate to an AAA user.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_aaa_user_certificate

ANSIBLE VERSION

v2.5

@dagwieers dagwieers added the aci Cisco ACI community label Jan 9, 2018
@dagwieers dagwieers added this to the 2.5.0 milestone Jan 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2018

cc @brunocalogero @jmcgill298 @schunduri
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 9, 2018
@dagwieers dagwieers force-pushed the aci_aaa_user_certificate branch 2 times, most recently from 3e03a16 to 7942377 Compare January 9, 2018 00:27
@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2018

@brunocalogero @jmcgill298 @schunduri

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@dagwieers
aci_user_certificate: Add a certificate to a user
092f777 
A new ACI module to add a X.509 certificate to a user.
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. test This PR relates to tests. labels Jan 9, 2018
@dagwieers dagwieers changed the title aci_user_certificate: Add a certificate to an AAA user aci_aaa_user_certificate: Add a certificate to an AAA user Jan 9, 2018
@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jan 9, 2018
@rsmeyers
Copy link

looks OK to me

@brunocalogero
Copy link
Contributor

brunocalogero commented Jan 10, 2018 •
edited
Loading

Also looks all good to me :)

@dagwieers dagwieers merged commit 2df6735 into ansible:devel Jan 10, 2018
@cpaggen
Copy link

cpaggen commented Jan 12, 2018

Tested: created cert, added to existing user in APIC, verified integrity of cert and tested operations using that cert for auth. Works with ACI 3.1.

@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dagwieers @ansibot @rsmeyers @brunocalogero @cpaggen