win_dns_client: Fix to compare ordering of resolver IP Addresses #34656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding "-SyncWindow 0" flag to the Compare-Object call used to determine if the existing and proposed IP address lists are the same. This makes the array comparison mark changes in order as a difference. Fix for bug ansible#34651
ansibot
added
affects_2.5
jborean93
removed
the
needs_triage
jborean93
approved these changes
Jan 11, 2018
|
Looks good @chriskarel, thanks for the PR |
|
Cherry-picked to stable-2.4 for the 2.4.3rc2 release. |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix for bug #34651
This change forces the module to consider the ordering of DNS entries when determining whether a change is needed. Previously, re-arranging the order of DNS resolvers was not detected as different, and therefore not changed.
ISSUE TYPE
COMPONENT NAME
win_dns_clinet
ANSIBLE VERSION
ADDITIONAL INFORMATION
Adding "-SyncWindow 0" flag to the Compare-Object call used to determine if the existing and proposed IP address lists are the same. This makes the array comparison mark changes in order as a difference.