Fixes python keyerror if no port is specified and default should be used

[grumpymatt]

SUMMARY

Received python keyerror when port value was missing. Used python dict get method to properly default the port value

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ANSIBLE VERSION

ansible 2.5.0 (devel d1846425db) last updated 2018/01/09 19:53:23 (GMT +000)
  config file = /home/itmxg01/ansible/vmware-provisioning/ansible.cfg
  configured module search path = [u'/home/itmxg01/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/itmxg01/ansible/ansible/lib/ansible
  executable location = /home/itmxg01/ansible/ansible/bin/ansible
  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]

ADDITIONAL INFORMATION

[ansibot]

cc @Akasurde @dav1x @jctanner @nerzhul
click here for bot help

[Akasurde]

Closing and re-opening for CI trigger.

[resmo]

The port is already defaulted https://github.com/grumpymatt/ansible/blob/4e4ea2508c65e2bfb7b4920ccb7e40d2f16cfc86/lib/ansible/module_utils/vmware.py#L440 and the key "port" does exist. I wonder if the error is related to a module not using the common arg spec.

[grumpymatt]

@resmo You are correct. I didn't realize we had a custom module using vmware.py and it was the one throwing the error. We have not updated it to the latest arg spec.

[grumpymatt]

I updated my custom module and it works now without this change. I think perhaps line 449 could still be updated since the port is specified elsewhere. Maybe a better change would be to remove the 'or 443'?

[ansibot]

cc @warthog9
click here for bot help

[Akasurde]

superseded by #37726