Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nxos_banner #34695

Merged
merged 1 commit into from Jan 11, 2018
Merged

fix nxos_banner #34695

merged 1 commit into from Jan 11, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Jan 10, 2018

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #34646
show banner .... returns [{u'banner_msg': {u'b_msg': u'User Access Verification\n'}}] on nxapi transport on some images. The PR handles this.

Note: This doesn't fix idempotence issue #29088 (comment) for nxapi

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_banner

ANSIBLE VERSION
devel

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha added networking Network category nxos Cisco NXOS community affects_2.4 This issue/PR affects Ansible v2.4 affects_2.5 This issue/PR affects Ansible v2.5 labels Jan 10, 2018
@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List Jan 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2018

@ansibot ansibot added bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 10, 2018
@trishnaguha trishnaguha merged commit 303894d into ansible:devel Jan 11, 2018
@trishnaguha trishnaguha deleted the nxos_banner_fix branch January 11, 2018 15:43
@abadger
Copy link
Contributor

abadger commented Jan 15, 2018

cherry-picked to stable-2.4 for the 2.4.3rc2 release.

abadger pushed a commit that referenced this pull request Jan 15, 2018
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 303894d)
@abadger abadger moved this from Nice to have to Done in 2.4.3 in 2.4.x Blocker List Jan 15, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.3
Development

Successfully merging this pull request may close these issues.

nxos_banner errors on both transport cli and nxapi
4 participants