New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nxos_banner #34695

Merged
merged 1 commit into from Jan 11, 2018

Conversation

3 participants
@trishnaguha
Member

trishnaguha commented Jan 10, 2018

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #34646
show banner .... returns [{u'banner_msg': {u'b_msg': u'User Access Verification\n'}}] on nxapi transport on some images. The PR handles this.

Note: This doesn't fix idempotence issue #29088 (comment) for nxapi

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_banner

ANSIBLE VERSION
devel
fix nxos_banner
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot

This comment has been minimized.

Show comment
Hide comment

@trishnaguha trishnaguha merged commit 303894d into ansible:devel Jan 11, 2018

1 check passed

Shippable Run 49966 status is SUCCESS.
Details

@trishnaguha trishnaguha deleted the trishnaguha:nxos_banner_fix branch Jan 11, 2018

@abadger

This comment has been minimized.

Show comment
Hide comment
@abadger

abadger Jan 15, 2018

Member

cherry-picked to stable-2.4 for the 2.4.3rc2 release.

Member

abadger commented Jan 15, 2018

cherry-picked to stable-2.4 for the 2.4.3rc2 release.

abadger added a commit that referenced this pull request Jan 15, 2018

fix nxos_banner (#34695)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 303894d)

@abadger abadger moved this from Nice to have to Done in 2.4.3 in 2.4.x Blocker List Jan 15, 2018

@ansibot ansibot added bug and removed bugfix_pull_request labels Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment