Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to openshift v0.4.1 #35127

Merged
merged 1 commit into from Feb 13, 2018
Merged

Upgrade to openshift v0.4.1 #35127

merged 1 commit into from Feb 13, 2018

Conversation

chouseknecht
Copy link
Contributor

@chouseknecht chouseknecht commented Jan 20, 2018 •
edited

SUMMARY

Upgrading to v0.4.1 of OpenShift client

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/k8s/helper.py

ANSIBLE VERSION
ansible 2.5.0 (feature/k8s-upgrade ed906fc520) last updated 2018/01/20 08:48:13 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/chouseknecht/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/chouseknecht/projects/ansible/lib/ansible
  executable location = /Users/chouseknecht/projects/ansible/bin/ansible
  python version = 2.7.14 (default, Nov 14 2017, 23:24:24) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.38)]

@ansibot
Copy link
Contributor

ansibot commented Jan 20, 2018

cc @fabianvf @flaper87 @maxamillion @sdoran
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 20, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 20, 2018
@chouseknecht
Copy link
Contributor Author

K8s Python Client 4.0

@ansible ansible deleted a comment from ansibot Jan 20, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 20, 2018
@maxamillion
Copy link
Contributor

The change looks good, however it seems like "Python Client 4.0" is referenced but in the requirements it's "openshift >= 0.4" and I wanted to verify that was intentional.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 22, 2018
@chouseknecht
Copy link
Contributor Author

@maxamillion

It's actually correct in the code, and wrong in the comments/commit message. The actual release is 0.4.0.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 22, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 6, 2018
@chouseknecht chouseknecht changed the title Upgrade to openshift 4.0 Upgrade to openshift v0.4.0 Feb 8, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 8, 2018
@chouseknecht chouseknecht changed the title Upgrade to openshift v0.4.0 Upgrade to openshift v0.4.1 Feb 12, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 12, 2018
@chouseknecht chouseknecht merged commit 69be2c1 into ansible:devel Feb 13, 2018
chouseknecht pushed a commit that referenced this pull request Feb 14, 2018
Upgrade to openshift client 0.4.0 (#35127)
4d79ab6
chouseknecht pushed a commit that referenced this pull request Feb 14, 2018
Revert "Upgrade to openshift client 0.4.0 (#35127)"
ac44b20
chouseknecht pushed a commit to chouseknecht/ansible that referenced this pull request Feb 14, 2018
Upgrade to openshift client 0.4.0 (ansible#35127)
f71d80e
nitzmahone pushed a commit that referenced this pull request Feb 14, 2018
@nitzmahone
Upgrade to openshift client 0.4.0 (#35127) (#36195)
b6c9630
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chouseknecht @ansibot @maxamillion