Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI: Move to 'host' parameter instead of 'hostname' #35161

Merged
merged 2 commits into from
Jan 22, 2018
Merged

ACI: Move to 'host' parameter instead of 'hostname' #35161

merged 2 commits into from
Jan 22, 2018

Conversation

dagwieers
Copy link
Contributor

SUMMARY

Since most network-related modules are using 'host' instead of 'hostname', it's probably best to make this the default parameter and change all examples equally.

This could be the first step towards provider-support ?

ISSUE TYPE
  • Feature Pull Request
  • Docs Pull Request
COMPONENT NAME

aci modules

ANSIBLE VERSION

v2.5

@dagwieers dagwieers added the aci Cisco ACI community label Jan 22, 2018
@dagwieers dagwieers added this to the 2.5.0 milestone Jan 22, 2018
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 22, 2018
@dagwieers dagwieers removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 22, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 22, 2018
@dagwieers
Copy link
Contributor Author

bot_broken ?

@ansibot ansibot added the bot_broken The bot is misbehaving. NOT for failing CI. A staff member will investigate. label Jan 22, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Jan 22, 2018

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@jmcgill298
Copy link
Contributor

ship it

@dagwieers dagwieers merged commit d600485 into ansible:devel Jan 22, 2018
dagwieers added a commit that referenced this pull request Jan 22, 2018
@dagwieers
Revert "ACI: Move to 'host' parameter instead of 'hostname' (#35161)"
9be2289 
This reverts commit d600485.
Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@dagwieers @Lujeni
ACI: Move to 'host' parameter instead of 'hostname' (ansible#35161)
a67b7f2 
* ACI: Move to 'host' parameter instead of 'hostname'

* Update host parameter in documentation fragment too
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added cisco Cisco technologies networking Network category labels Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 bot_broken The bot is misbehaving. NOT for failing CI. A staff member will investigate. cisco Cisco technologies feature This issue/PR relates to a feature request. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagwieers @jmcgill298 @ansibot