Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests for influxdb_user module #35315

Merged
merged 2 commits into from Jan 27, 2018
Merged

Integration tests for influxdb_user module #35315

merged 2 commits into from Jan 27, 2018

Conversation

ar7z1
Copy link
Contributor

@ar7z1 ar7z1 commented Jan 24, 2018 •
edited

SUMMARY

In this PR I've added integration tests for influxdb_user module.
For simplicity, I run tests only on Ubuntu 14.04 (as zabbix_host tests does).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

influxdb_user

ANSIBLE VERSION
ansible 2.5.0 (3237-change-rabbitmq-user-password-without-force 4cdda0d9a3) last updated 2018/01/23 21:56:35 (GMT +300)
  config file = /home/art/.ansible.cfg
  configured module search path = [u'/home/art/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/art/projects/github/ansible/lib/ansible
  executable location = /home/art/projects/github/ansible/bin/ansible
  python version = 2.7.12 (default, Nov 20 2017, 18:23:56) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

@ar7z1 ar7z1 changed the title Added integration tests for influxdb_user module Integration tests for influxdb_user module Jan 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 24, 2018

cc @kamsz @zhhuta
click here for bot help

@ansibot ansibot added feature_pull_request needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Jan 24, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jan 25, 2018
@Akasurde Akasurde requested a review from resmo January 25, 2018 04:28
@Akasurde
Copy link
Member

@ar7z1 Thanks for integration test.

@ar7z1
Copy link
Contributor Author

ar7z1 commented Jan 25, 2018

I've just realised that shippable doesn't run privileged tests. I'll fix it soon. :-)

@ar7z1 ar7z1 changed the title Integration tests for influxdb_user module [WIP] Integration tests for influxdb_user module Jan 25, 2018
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jan 25, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Jan 25, 2018

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jan 25, 2018
@ar7z1 ar7z1 changed the title [WIP] Integration tests for influxdb_user module Integration tests for influxdb_user module Jan 25, 2018
@ar7z1
Copy link
Contributor Author

ar7z1 commented Jan 25, 2018

ready_for_review

@ansibot ansibot removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jan 25, 2018
@resmo
Copy link
Contributor

resmo commented Jan 26, 2018

good job,

I would even add some more tests for idempotency checking and check mode, see https://github.com/ansible/ansible/blob/devel/test/integration/targets/cs_account/tasks/main.yml#L31 as an example. you basically run the module 3 times:

  • in check mode (expect changed)
  • without check mode (expect changed)
  • and again without check mode (expect not changed).

Would you like to extend the tests before we merge?

@ar7z1
Copy link
Contributor Author

ar7z1 commented Jan 26, 2018 •
edited

@resmo, Thanks for review! Sure, I'll extend the tests. :-)

@ar7z1
Copy link
Contributor Author

ar7z1 commented Jan 26, 2018

@resmo, Added tests in 4300297. Can you review the changes?

@resmo
Copy link
Contributor

resmo commented Jan 27, 2018

looks good to me

shipit

@ar7z1
Copy link
Contributor Author

ar7z1 commented Jan 27, 2018

@resmo Thank you for review!

@ar7z1
Copy link
Contributor Author

ar7z1 commented Jan 27, 2018

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jan 27, 2018

Components

test/integration/targets/influxdb_user/aliases
support: community
maintainers: kamsz zhhuta

test/integration/targets/influxdb_user/meta/main.yml
support: community
maintainers: kamsz zhhuta

test/integration/targets/influxdb_user/tasks/main.yml
support: community
maintainers: kamsz zhhuta

test/integration/targets/influxdb_user/tasks/tests.yml
support: community
maintainers: kamsz zhhuta

test/integration/targets/setup_influxdb/tasks/main.yml
support: community
maintainers:

test/integration/targets/setup_influxdb/tasks/setup.yml
support: community
maintainers:

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:

click here for bot help

@ar7z1
Copy link
Contributor Author

ar7z1 commented Jan 27, 2018

@zhhuta, can you look at this PR?

@Akasurde Akasurde merged commit 1f1402e into ansible:devel Jan 27, 2018
@Akasurde
Copy link
Member

@ar7z1 Thanks for the contribution. @resmo Thanks for review.

@ar7z1 ar7z1 deleted the influxdb_user-tests branch January 27, 2018 14:48
@ar7z1 ar7z1 mentioned this pull request Jan 27, 2018
Merged
@mattclay
Copy link
Member

I've temporarily disabled this test in CI as it is conflicting with the uri test: https://app.shippable.com/github/ansible/ansible/runs/52740/23/tests

Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@ar7z1 @Lujeni
Integration tests for influxdb_user module (ansible#35315)
060666e 
* Added integration tests for influxdb_user
* Tests for idempotency checking and check mode
@ar7z1 ar7z1 mentioned this pull request Feb 6, 2018
Closed
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ar7z1 @ansibot @Akasurde @resmo @mattclay