Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added aci_static_binding_to_epg module #35581

Merged
merged 5 commits into from
Feb 2, 2018
Merged

added aci_static_binding_to_epg module #35581

merged 5 commits into from
Feb 2, 2018

Conversation

brunocalogero
Copy link
Contributor

SUMMARY

added aci_static_binding_to_epg module (fv:RsPathAtt)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_static_binding_to_epg

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

Also resolves the following issue: #35340

@brunocalogero brunocalogero mentioned this pull request Jan 31, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

cc @dagwieers @jmcgill298 @schunduri
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. aci Cisco ACI community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. ci_verified Changes made in this PR are causing tests to fail. labels Jan 31, 2018
@brunocalogero
Copy link
Contributor Author

@dagwieers man.. these documentation errors :P is it because I have to provide either "choices" or "aliases" for every parameter in the doc ?

@dagwieers
Copy link
Contributor

@brunocalogero Well, it means you have a YAML error in the documentation. What I usually do is copy&paste into yamllint to find the cause.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 31, 2018
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed ci_verified Changes made in this PR are causing tests to fail. labels Feb 1, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 1, 2018
@ansible ansible deleted a comment from ansibot Feb 1, 2018
@ansible ansible deleted a comment from ansibot Feb 1, 2018
@ansible ansible deleted a comment from ansibot Feb 1, 2018
dagwieers
dagwieers suggested changes Feb 1, 2018
View reviewed changes
lib/ansible/modules/network/aci/aci_static_binding_to_epg.py Outdated
default: access_interface
pod:
description:
- the pod number part of the tDn.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start with a capital.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same for other descriptions.

lib/ansible/modules/network/aci/aci_static_binding_to_epg.py Outdated
pod:
description:
- the pod number part of the tDn.
- C(pod) is usually an integer below 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End with a dot.

@dagwieers dagwieers mentioned this pull request Feb 1, 2018
Closed
@brunocalogero brunocalogero changed the title WIP: added aci_static_binding_to_epg module added aci_static_binding_to_epg module Feb 2, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Feb 2, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 2, 2018
@dagwieers dagwieers merged commit 767f32c into ansible:devel Feb 2, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers requested changes

Assignees
No one assigned
Labels
aci Cisco ACI community cisco Cisco technologies module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunocalogero @ansibot @dagwieers