Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional result output #35819

Conversation

mbloch1986
Copy link

@mbloch1986 mbloch1986 commented Feb 7, 2018

SUMMARY

In order to get the message-id of the published command it would make sense to pass through the output of the publish command to ansible.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module: sns

ANSIBLE VERSION
ansible 2.4.2.0
  config file = None
  configured module search path = [u'/Users/mbloch/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Library/Python/2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.10 (default, Jul 15 2017, 17:16:57) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION
Before:
TASK [Send message to SNS Topic] *************************************************************************************************************************************************************************************************************
ok: [127.0.0.1] => {"changed": false, "msg": "OK"}


After:
TASK [Send message to SNS Topic] *************************************************************************************************************************************************************************************************************
ok: [127.0.0.1] => {"changed": false, "item": {"PublishResponse": {"PublishResult": {"MessageId": "599e393c-546a-5ee8-afdc-6bc821aacadb"}, "ResponseMetadata": {"RequestId": "25f44f95-a411-5280-9ed0-1d61d1d1c6b3"}}}, "msg": "OK"}

Pass through the output of the connection.publish command to exit_json to get the message-id of the sent command.
@ansibot
Copy link
Contributor

ansibot commented Feb 7, 2018

@ansibot ansibot added aws cloud community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 7, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 7, 2018

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/sns.py:227:28: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/amazon/sns.py:228:28: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 7, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 8, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 9, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 17, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 21, 2018
@mbloch1986
Copy link
Author

Done with #45634

@mbloch1986 mbloch1986 closed this Oct 9, 2018
@mbloch1986 mbloch1986 deleted the enhancement/Additional-result-output branch October 9, 2018 03:21
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 aws cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants