-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wording of Going Further section #35949
Merged
dharmabumstead
merged 4 commits into
ansible:devel
from
rvgate:fix_going-further_wording
Feb 11, 2018
Merged
Change wording of Going Further section #35949
dharmabumstead
merged 4 commits into
ansible:devel
from
rvgate:fix_going-further_wording
Feb 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original wording was confusing with its non-devel branch part. Made it much clearer for people to understand what to do. Also removed the git command for creating branches, I believe a develop should be aware of how basic git commands work.
gundalow
approved these changes
Feb 9, 2018
nkakouros
reviewed
Feb 9, 2018
in your fork. When you believe you have a good working code change, | ||
submit a pull request to the Ansible repository. | ||
If you would like to contribute to the main Ansible repository | ||
by by adding a new feature or fixing a bug, `create a fork <https://help.github.com/articles/fork-a-repo/>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'by' is given twice in the beginning of the sentence
dharmabumstead
approved these changes
Feb 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with edits. Thanks @rvgate!
gundalow
pushed a commit
to gundalow/ansible
that referenced
this pull request
Feb 12, 2018
* Change wording of Going Further section The original wording was confusing with its non-devel branch part. Made it much clearer for people to understand what to do. Also removed the git command for creating branches, I believe a develop should be aware of how basic git commands work. * Edited for concision and clarity. * Typo fix * Typo fix (cherry picked from commit d5ae63c)
gundalow
added a commit
that referenced
this pull request
Feb 12, 2018
* Change wording of Going Further section The original wording was confusing with its non-devel branch part. Made it much clearer for people to understand what to do. Also removed the git command for creating branches, I believe a develop should be aware of how basic git commands work. (cherry picked from commit d5ae63c)
Cherry picked into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
docs
This issue/PR relates to or includes documentation.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original wording was confusing with its non-devel branch part.
Made it much clearer for people to understand what to do.
Also removed the git command for creating branches, I believe a
develop should be aware of how basic git commands work.
ISSUE TYPE