Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording of Going Further section #35949

Merged
merged 4 commits into from
Feb 11, 2018

Conversation

rvgate
Copy link
Contributor

@rvgate rvgate commented Feb 9, 2018

The original wording was confusing with its non-devel branch part.
Made it much clearer for people to understand what to do.

Also removed the git command for creating branches, I believe a
develop should be aware of how basic git commands work.

ISSUE TYPE
  • Docs Pull Request

The original wording was confusing with its non-devel branch part.
Made it much clearer for people to understand what to do.

Also removed the git command for creating branches, I believe a
develop should be aware of how basic git commands work.
@ansibot ansibot added docs_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 9, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Feb 9, 2018
in your fork. When you believe you have a good working code change,
submit a pull request to the Ansible repository.
If you would like to contribute to the main Ansible repository
by by adding a new feature or fixing a bug, `create a fork <https://help.github.com/articles/fork-a-repo/>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'by' is given twice in the beginning of the sentence

Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with edits. Thanks @rvgate!

@dharmabumstead dharmabumstead merged commit d5ae63c into ansible:devel Feb 11, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Feb 12, 2018
* Change wording of Going Further section

The original wording was confusing with its non-devel branch part.
Made it much clearer for people to understand what to do.

Also removed the git command for creating branches, I believe a
develop should be aware of how basic git commands work.

* Edited for concision and clarity.

* Typo fix

* Typo fix

(cherry picked from commit d5ae63c)
gundalow added a commit that referenced this pull request Feb 12, 2018
* Change wording of Going Further section

The original wording was confusing with its non-devel branch part.
Made it much clearer for people to understand what to do.

Also removed the git command for creating branches, I believe a
develop should be aware of how basic git commands work.

(cherry picked from commit d5ae63c)
@gundalow
Copy link
Contributor

Cherry picked into stable-2.5 72ad157

@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants