Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VyOS check mode #35977

Merged
merged 2 commits into from Feb 11, 2018
Merged

Fix VyOS check mode #35977

merged 2 commits into from Feb 11, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Feb 9, 2018 •
edited

SUMMARY

Fixes #35625
Also reverts related test removal

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vyos

ANSIBLE VERSION
2.5

@Qalthos
Revert "commented out check tests (ansible#35788)"
0b5b196 
This reverts commit 3df2561.
@Qalthos
discard_changes() now uses exit discard
9b820b6 
instead of just `discard`. Also a slight tweak to avoid a second `exit` after
`exit discard`
@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2018

cc @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 9, 2018
@Qalthos Qalthos removed the needs_triage Needs a first human triage before being processed. label Feb 9, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 9, 2018
@Qalthos Qalthos merged commit 6cdf91f into ansible:devel Feb 11, 2018
@Qalthos Qalthos deleted the vyos-fix branch February 11, 2018 16:40
Qalthos added a commit to Qalthos/ansible that referenced this pull request Feb 13, 2018
@Qalthos
Fix VyOS check mode (ansible#35977)
d1ab59e 
* Revert "commented out check tests (ansible#35788)"

This reverts commit 3df2561.

* `discard_changes()` now uses `exit discard`

instead of just `discard`. Also a slight tweak to avoid a second `exit` after
`exit discard`

(cherry picked from commit 6cdf91f)
Qalthos added a commit that referenced this pull request Feb 13, 2018
@Qalthos
Fix VyOS check mode (#35977) (#36114)
707fd61 
* Revert "commented out check tests (#35788)"

This reverts commit 3df2561.

* `discard_changes()` now uses `exit discard`

instead of just `discard`. Also a slight tweak to avoid a second `exit` after
`exit discard`

(cherry picked from commit 6cdf91f)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@gundalow gundalow Awaiting requested review from gundalow

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@newswangerd newswangerd Awaiting requested review from newswangerd

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vyos interface throws a traceback in check mode
3 participants
@Qalthos @ansibot @ganeshrn