Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Additional check for RootSnapshot #36001

Merged
merged 1 commit into from Feb 10, 2018
Merged

VMware: Additional check for RootSnapshot #36001

merged 1 commit into from Feb 10, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

This fix adds an additional check if there is no snapshot available
in VM. rootSnapshotList is None, if no snapshot is taken.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_guest_snapshot.py

ANSIBLE VERSION
2.5devel

@Akasurde
VMware: Additional check for RootSnapshot
e31874c 
This fix adds an additional check if there is no snapshot available
in VM. `rootSnapshotList` is None, if no snapshot is taken.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Feb 10, 2018

cc @Akasurde @dav1x @jctanner @nerzhul
click here for bot help

@ansibot ansibot added bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Feb 10, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Feb 10, 2018
@Akasurde Akasurde merged commit 52f79fa into ansible:devel Feb 10, 2018
@Akasurde Akasurde deleted the snapshot_fix branch February 10, 2018 15:41
Akasurde added a commit to Akasurde/ansible that referenced this pull request Feb 14, 2018
@Akasurde
VMware: Additional check for RootSnapshot (ansible#36001)
fcdce32 
This fix adds an additional check if there is no snapshot available
in VM. `rootSnapshotList` is None, if no snapshot is taken.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit 52f79fa)
gundalow pushed a commit that referenced this pull request Feb 14, 2018
@Akasurde @gundalow
VMware: Additional check for RootSnapshot (#36001) (#36166)
b7f1163 
This fix adds an additional check if there is no snapshot available
in VM. `rootSnapshotList` is None, if no snapshot is taken.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit 52f79fa)
@gundalow
Copy link
Contributor

Merged into devel and cherry-picked into stable-2.5

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Akasurde @ansibot @gundalow