Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ansible-console always asking for vault passwords #36244

Merged
merged 1 commit into from Feb 15, 2018
Merged

Fix ansible-console always asking for vault passwords #36244

merged 1 commit into from Feb 15, 2018

Conversation

alikins
Copy link
Contributor

@alikins alikins commented Feb 15, 2018

SUMMARY

Fix ansible-console always asking for vault passwords

ansible-console was calling setup_vault_secrets
twice. Once directly and once via _play_prereqs()

The direct invocation was not setting auto_prompt=False.

However, the direct invocation isn't need at all so
this removes it so only _play_reqs() is used.
That fixes the unrequested vault password
prompting.

Fixes #33027

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/cli/console.py

ANSIBLE VERSION
ansible 2.6.0 (console_vault_auto_prompt_33027 c417dc547f) last updated 2018/02/15 11:07:35 (GMT -400)
  config file = None
  configured module search path = [u'/home/adrian/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/adrian/src/ansible/lib/ansible
  executable location = /home/adrian/src/ansible/bin/ansible
  python version = 2.7.14 (default, Jan 17 2018, 14:28:32) [GCC 7.2.1 20170915 (Red Hat 7.2.1-2)]


ADDITIONAL INFORMATION

Likely candidate for backporting to stable-2.4/stable-2.5


ansible-console was calling setup_vault_secrets
twice. Once directly and once via _play_prereqs()

The direct invocation was not setting auto_prompt=False.

However, the direct invocation isn't need at all so
this removes it so only _play_reqs() is used.
That fixes the unrequested vault password
prompting.

Fixes #33027
@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 15, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 15, 2018
@bcoca bcoca merged commit 810fa70 into ansible:devel Feb 15, 2018
@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Feb 15, 2018
@bcoca bcoca moved this from To Do to In Progress in 2.5.x blocker list Feb 15, 2018
@bcoca bcoca added this to Nice to have in 2.4.x Blocker List Feb 15, 2018
@bcoca bcoca moved this from Nice to have to Blocker in 2.4.x Blocker List Feb 15, 2018
@abadger abadger moved this from Blocker to Nice to have in 2.4.x Blocker List Feb 15, 2018
@bcoca bcoca moved this from Nice to have to Blocker in 2.4.x Blocker List Feb 15, 2018
@bcoca bcoca moved this from Blocker to Done in 2.4.4 in 2.4.x Blocker List Feb 15, 2018
@bcoca bcoca moved this from In Progress to Done in 2.5.x blocker list Feb 16, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ansible-console asks for vault password
3 participants