Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_install_os Remove kickstart_image_required check #36319

Merged
merged 1 commit into from Feb 17, 2018
Merged

nxos_install_os Remove kickstart_image_required check #36319

merged 1 commit into from Feb 17, 2018

Conversation

mikewiebe
Copy link
Contributor

SUMMARY

This update removes a check to indicate if a kickstart image is required or not. It's possible to upgrade from a system that requires both a kickstart and system image to the singe image that combines the system/kickstart. This check needs to be removed to allow these kinds of upgrades.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_os_install

ANSIBLE VERSION
ansible 2.6.0 (rel250/fix_nxos_os_install 6f5af5c195) last updated 2018/02/16 13:17:54 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/mwiebe/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/lib/ansible
  executable location = /Users/mwiebe/Projects/nxos_ansible/fix_ansible/bin/ansible
  python version = 2.7.13 (default, Apr  4 2017, 08:47:57) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.38)]
ADDITIONAL INFORMATION

This update needs to be included in 2.5.

@mikewiebe
Copy link
Contributor Author

@trishnaguha Update we spoke about earlier. Need this in 2.5.

@ansibot
Copy link
Contributor

ansibot commented Feb 16, 2018

cc @GGabriele @jedelman8 @kedarX @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Feb 16, 2018
@trishnaguha trishnaguha self-assigned this Feb 17, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2018
@trishnaguha trishnaguha changed the title Remove kickstart_image_required check nxos_install_os Remove kickstart_image_required check Feb 17, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Feb 17, 2018
@trishnaguha trishnaguha merged commit 6e096cb into ansible:devel Feb 17, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Feb 17, 2018
@mikewiebe @trishnaguha
Remove kickstart_image_required check (ansible#36319)
6ca79af 
(cherry picked from commit 6e096cb)
trishnaguha added a commit that referenced this pull request Feb 17, 2018
@trishnaguha
Remove kickstart_image_required check (#36319) (#36342)
f5fa91c 
(cherry picked from commit 6e096cb)
@trishnaguha
Copy link
Member

@mikewiebe Thanks for the PR. cherry-picked to stable-2.5

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@mikewiebe mikewiebe deleted the rel250/fix_nxos_os_install branch November 26, 2018 18:06
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikewiebe @ansibot @trishnaguha @dagwieers