Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_bgp_neighbor_af issues #36472

Merged
merged 1 commit into from Feb 21, 2018
Merged

fix nxos_bgp_neighbor_af issues #36472

merged 1 commit into from Feb 21, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Feb 20, 2018 •
edited

SUMMARY

Fixes #36471

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_bgp_neighbor_af

ANSIBLE VERSION
ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR fixes issues in nxos_bgp_neighbor_af issues #36471
  • Integration test cases are enhanced for nxos_bgp_neighbor_af module to include all parameters and for taking care of platform differences.
  • Tested on all possible platforms and versions.

@ansibot
Copy link
Contributor

ansibot commented Feb 20, 2018

cc @GGabriele @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Feb 20, 2018
@trishnaguha trishnaguha self-assigned this Feb 21, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Feb 21, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Feb 21, 2018
@trishnaguha trishnaguha mentioned this pull request Feb 21, 2018
Closed
@trishnaguha trishnaguha merged commit 47a9238 into ansible:devel Feb 21, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Feb 21, 2018
@trishnaguha
fix nxos_bgp_neighbor_af issues (ansible#36472)
f93c6c1 
(cherry picked from commit 47a9238)
trishnaguha added a commit that referenced this pull request Feb 21, 2018
@trishnaguha
fix nxos_bgp_neighbor_af issues (#36472) (#36481)
d86d490 
(cherry picked from commit 47a9238)
@trishnaguha
Copy link
Member

@saichint Thanks for the PR. cherry-picked to stable-2.5 d86d490

@saichint saichint deleted the bgp branch February 21, 2018 17:13
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_bgp_neighbor_af issues
4 participants
@saichint @ansibot @trishnaguha @dagwieers