Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSO ValueBuilder improvements. 4.5 leaf-list compatability. #36583

Merged
merged 1 commit into from Feb 26, 2018
Merged

NSO ValueBuilder improvements. 4.5 leaf-list compatability. #36583

merged 1 commit into from Feb 26, 2018

Conversation

cnasten
Copy link
Contributor

@cnasten cnasten commented Feb 22, 2018

Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.

SUMMARY

Detect and use union types, manage leaf-list as list in 4.5 and later and don't fail if a type is unknown, just skip the identityref mapping.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nso_config

ANSIBLE VERSION
ansible 2.6.0 (nso_config_leaf_list_devel_36509 b62cd22abc) last updated 2018/02/22 15:12:59 (GMT +200)
  config file = None
  configured module search path = [u'/home/cnasten/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/cnasten/dev/ansible/lib/ansible
  executable location = /home/cnasten/dev/ansible/bin/ansible
  python version = 2.7.14+ (default, Feb  6 2018, 19:12:18) [GCC 7.3.0]
ADDITIONAL INFORMATION

@cnasten
NSO ValueBuilder improvements. 4.5 leaf-list compatability.
b62cd22 
Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.
@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2018

cc @Qalthos @cmoberg @ganeshrn @gundalow @kedarX @pekdon @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 22, 2018
@cnasten
Copy link
Contributor Author

cnasten commented Feb 23, 2018

shipit

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Feb 23, 2018
@cmoberg
Copy link

cmoberg commented Feb 23, 2018

shipit

@gundalow
Copy link
Contributor

Hi, could you please update the maintainer's list in https://github.com/ansible/ansible/blob/devel/.github/BOTMETA.yml in a separate PR.

That will add the owners_pr label, which basically means "We trust you are doing the right thing and will merge this"

@gundalow
Copy link
Contributor

Does this need to go into stable-2.5 as well?

@cnasten
Copy link
Contributor Author

cnasten commented Feb 23, 2018

PR for team_nso created, #36652

And yeah, this and two upcoming PRs would be great if they could go into the 2.5 stable tree. One for updated list of compatible NSO versions and one work-around for an issue in NSO.

@gundalow gundalow merged commit 2789cc5 into ansible:devel Feb 26, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Feb 26, 2018
@cnasten @gundalow
NSO ValueBuilder improvements. 4.5 leaf-list compatability. (ansible#…
d0e632a 
…36583)

Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.
(cherry picked from commit 2789cc5)
@gundalow
Copy link
Contributor

Merged into devel PR created for 2.5, will merge once shippable is green #36735

gundalow added a commit that referenced this pull request Feb 26, 2018
@gundalow
NSO ValueBuilder improvements. 4.5 leaf-list compatability. (#36583) (#…
5052db2 
…36735)

Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.
(cherry picked from commit 2789cc5)
@gundalow
Copy link
Contributor

stable-2.5 updated

@cnasten cnasten mentioned this pull request Mar 2, 2018
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added nso Cisco NSO community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. cisco Cisco technologies networking Network category nso Cisco NSO community support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cnasten @ansibot @cmoberg @gundalow @dagwieers @mkrizek