Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of tests for modify_module #36602

Merged
merged 1 commit into from Feb 22, 2018
Merged

Start of tests for modify_module #36602

merged 1 commit into from Feb 22, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Feb 22, 2018

SUMMARY

Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules

See #36536

NOTE: These tests do not work on 2.4 due to modify_module not accepting a templar kwarg

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/units/executor/module_common/test_modify_module.py

ANSIBLE VERSION
2.4
2.5
2.6
ADDITIONAL INFORMATION

@sivel sivel requested a review from abadger February 22, 2018 21:56
@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 22, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 22, 2018
@sivel sivel merged commit a7062b7 into ansible:devel Feb 22, 2018
sivel added a commit to sivel/ansible that referenced this pull request Feb 22, 2018
…ng replacement on old style modules (ansible#36602)

(cherry picked from commit a7062b7)
sivel added a commit to sivel/ansible that referenced this pull request Feb 22, 2018
…ng replacement on old style modules (ansible#36602)

(cherry picked from commit a7062b7)
nitzmahone pushed a commit that referenced this pull request Feb 22, 2018
…ng replacement on old style modules (#36602) (#36606)

(cherry picked from commit a7062b7)
sivel added a commit that referenced this pull request Feb 22, 2018
* Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules (#36602)

(cherry picked from commit a7062b7)

* Modify test to work on 2.4 due to lacking templar kwarg
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants