Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuring sftp/scp executables #36648

Merged
merged 4 commits into from Apr 23, 2018
Merged

allow configuring sftp/scp executables #36648

merged 4 commits into from Apr 23, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Feb 23, 2018

SUMMARY

adds new config options to ssh connection plugin to allow specifying sftp/scp executables to use.

fixes #36616

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

connection/ssh

ANSIBLE VERSION
2.7

@ansibot ansibot added feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 23, 2018
@bcoca bcoca added this to the 2.7.0 milestone Feb 23, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 23, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 23, 2018
@bcoca bcoca mentioned this pull request Feb 23, 2018
Closed
@wrouesnel
Copy link
Contributor

Looks perfect! And yes much simpler.

@mattclay
Copy link
Member

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/55931/3/tests

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 28, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 10, 2018
@ansibot ansibot added test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 10, 2018
@ansible ansible deleted a comment from ansibot Apr 10, 2018
@mattclay
Copy link
Member

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/60742/3/tests

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 10, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 16, 2018
@bcoca bcoca merged commit 4aac0f5 into ansible:devel Apr 23, 2018
@bcoca bcoca deleted the other_ssh_exes branch April 23, 2018 22:36
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@bcoca
allow configuring sftp/scp executables (ansible#36648)
91ddcba 
* allow configuring sftp/scp executables

fixes ansible#36616


also removed dupe test
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@bcoca
allow configuring sftp/scp executables (ansible#36648)
2f55f10 
* allow configuring sftp/scp executables

fixes ansible#36616


also removed dupe test
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bcoca @ilicmilan
allow configuring sftp/scp executables (ansible#36648)
4a02c6f 
* allow configuring sftp/scp executables

fixes ansible#36616


also removed dupe test
@bcoca bcoca mentioned this pull request Apr 10, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

Need ansible_scp_executable and ansible_sftp_executable
4 participants
@bcoca @wrouesnel @mattclay @ansibot