Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protocol restriction for SRV records in cloudflare_dns module. Fixes #36708 #36709

Merged
merged 1 commit into from Mar 9, 2018
Merged

Remove protocol restriction for SRV records in cloudflare_dns module. Fixes #36708 #36709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ Ansible Changes By Release
See [Porting Guide](http://docs.ansible.com/ansible/devel/porting_guides/porting_guides.html) for more information

### Minor Changes
* Removed restriction from protocol in cloudflare_dns module to allow other protocols than tcp and udp to be specified.

#### Removed modules (previously deprecated)

Expand Down
5 changes: 2 additions & 3 deletions lib/ansible/modules/net_tools/cloudflare_dns.py
View file
Open in desktop
Expand Up @@ -42,9 +42,8 @@
required: false
default: "1"
proto:
description: Service protocol. Required for C(type=SRV)
description: Service protocol. Required for C(type=SRV). Common values are tcp and udp. (Before Ansible 2.6 only tcp and udp were available).
required: false
choices: [ 'tcp', 'udp' ]
default: null
proxied:
description: Proxy through cloudflare network or just use DNS
Expand Down Expand Up @@ -602,7 +601,7 @@ def main():
account_email=dict(required=True, type='str'),
port=dict(required=False, default=None, type='int'),
priority=dict(required=False, default=1, type='int'),
proto=dict(required=False, default=None, choices=['tcp', 'udp'], type='str'),
proto=dict(required=False, default=None, type='str'),
proxied=dict(required=False, default=False, type='bool'),
record=dict(required=False, default='@', aliases=['name'], type='str'),
service=dict(required=False, default=None, type='str'),
Expand Down