Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nso_config work around ordering issues #36774

Merged
merged 1 commit into from Feb 27, 2018
Merged

nso_config work around ordering issues #36774

merged 1 commit into from Feb 27, 2018

Conversation

cnasten
Copy link
Contributor

@cnasten cnasten commented Feb 27, 2018

Include dependencies when sorting entries to avoid issues with
certain versions of NSO.

SUMMARY

Some version of NSO evaluate dependencies during path parsing (instead of the validate step) and thus requires elements to be set in order. Work-around this by sorting the values using the provided dependency information if any.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nso_config

ANSIBLE VERSION
ansible 2.6.0 (nso_config_order_work_around e7f93f3b37) last updated 2018/02/27 09:40:20 (GMT +200)
  config file = None
  configured module search path = [u'/home/cnasten/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/cnasten/dev/ansible/lib/ansible
  executable location = /home/cnasten/dev/ansible/bin/ansible
  python version = 2.7.14+ (default, Feb  6 2018, 19:12:18) [GCC 7.3.0]
ADDITIONAL INFORMATION

NA

@cnasten
nso_config work around ordering issues
468b0d7 
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2018

cc @Qalthos @cmoberg @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 27, 2018
@gundalow
Copy link
Contributor

@cmoberg could you please review.
Looks like this would need to go into 2.5 as well?

Nice to see tests added to defend the bug fixes.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 27, 2018
@cnasten
Copy link
Contributor Author

cnasten commented Feb 27, 2018

Yep, this should go into 2.5 if possible.

@cmoberg
Copy link

cmoberg commented Feb 27, 2018

shipit

1 similar comment
@cnasten
Copy link
Contributor Author

cnasten commented Feb 27, 2018

shipit

@gundalow gundalow merged commit e75989e into ansible:devel Feb 27, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Feb 27, 2018
@cnasten @gundalow
nso_config work around ordering issues (ansible#36774)
c8efbbd 
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
(cherry picked from commit e75989e)
gundalow added a commit that referenced this pull request Feb 27, 2018
@gundalow
nso_config work around ordering issues (#36774) (#36785)
19ea7bc 
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
(cherry picked from commit e75989e)
@gundalow
Copy link
Contributor

Merged into devel and cherry picked into stable-2.5 19ea7bc

Thanks

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added nso Cisco NSO community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. cisco Cisco technologies networking Network category nso Cisco NSO community support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cnasten @ansibot @gundalow @cmoberg @dagwieers