Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix junos_command py3 related issues (#36782) #36895

Merged
merged 1 commit into from Mar 1, 2018
Merged

Fix junos_command py3 related issues (#36782) #36895

merged 1 commit into from Mar 1, 2018

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Mar 1, 2018

SUMMARY

Fixes #36204

  • tostring() input string shoulb be in byte string format
  • to_ele() input is required in unicode format
    (cherry picked from commit 41d7578)

merged to devel #36782

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_command

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

@ganeshrn
Fix junos_command py3 related issues (ansible#36782)
a045062 
Fixes ansible#36204

*  tostring() input string shoulb be in byte string format
*  to_ele() input is required in unicode format
(cherry picked from commit 41d7578)
@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2018

cc @Qalthos @gdpak @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Mar 1, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Mar 1, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 1, 2018
@ganeshrn ganeshrn merged commit dce80b1 into ansible:stable-2.5 Mar 1, 2018
@ganeshrn ganeshrn deleted the backport/2.5/36782 branch March 1, 2018 08:59
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganeshrn @ansibot