Fixes 36950. Added support for missing options capabilities and root_device in properties of os_ironic.py ansible module #37113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test |
ansibot
added
bug
|
cc @dagnello @emonty @j2sol @juliakreger @rcarrillocruz @Shrews @Thingee |
gundalow
reviewed
Mar 7, 2018
| default: "" | ||
| root_device: | ||
| description: | ||
| - Root disk selections. eg: /dev/sda |
There was a problem hiding this comment.
Having an extra : confuses the yaml parser, perhaps
Root disk selection, such as C(/dev/sda)
The example and documentation don't seem to match up. In the EXAMPLE it looks like it may support a list
ansibot
removed
the
needs_triage
|
Build succeeded (third-party-check pipeline).
|
ansibot
added
community_review
|
Build succeeded (third-party-check pipeline).
|
ansibot
added
the
stale_ci
|
Any comments? |
juliakreger
approved these changes
May 11, 2018
There was a problem hiding this comment.
You should change references from pike to latest. i.e. https://docs.openstack.org/ironic/latest
Additionally.... /dev/md0 would never really be valid. /dev/sda is better... but I can see the reference in our own docs in ironic. facepalm
…t_device in properties of os_ironic.py ansible module
sekharvajjula
force-pushed
the
os_ironic_36950
branch
from
3f270d7
to
8cc93a2
Compare
ansibot
removed
the
stale_ci
|
Build succeeded (third-party-check pipeline).
|
|
Build succeeded (third-party-check pipeline).
|
ansibot
added
core_review
ansibot
added
community_review
|
shipit |
|
Any plans when this change would be accepted? |
gundalow
reviewed
Dec 12, 2018
ansibot
added
needs_revision
gundalow
added
feature
|
rebuild_merge |
odyssey4me
approved these changes
Dec 12, 2018
|
shipit |
ansibot
added
community_review
|
Build succeeded (third-party-check pipeline).
|
|
Thank you!! |
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
…device in properties of os_ironic.py ansible module (ansible#37113) * Fix for 36950. Added support for missing options capabilities and root_device in properties of os_ironic.py ansible module * Updated docstring to pass documentation validation * Updated review comments from juliakreger * version_added: "2.8"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support for missing options capabilities and root_device in properties of os_ironic.py ansible module
Fixes: #36950
ISSUE TYPE
COMPONENT NAME
os_ironic.py
ANSIBLE VERSION
ADDITIONAL INFORMATION