Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples fix: mode selection #37128

Merged
merged 1 commit into from Mar 8, 2018
Merged

examples fix: mode selection #37128

merged 1 commit into from Mar 8, 2018

Conversation

arendej
Copy link
Contributor

@arendej arendej commented Mar 7, 2018

SUMMARY

Documentation:
Mode selection in the examples didn't match (or work) for system: true.
It should be
mode: <mode here>

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

atomic_container

ANSIBLE VERSION
ansible 2.4.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]
ADDITIONAL INFORMATION
# before:
fatal: [ansible-node-hostname]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (atomic_container) module: system Supported parameters include: backend,image,mode,name,rootfs,state,values"}

# after:
no such error as above.

@arendej
examples fix: mode selection
69033c5 
Mode selection in the examples didn't match (or work) for system: true.
It should be 
`mode: <mode here>`
@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2018

cc @giuseppe @krsacme
click here for bot help

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 7, 2018
@giuseppe
Copy link
Contributor

giuseppe commented Mar 7, 2018

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 7, 2018
@krsacme
Copy link
Contributor

krsacme commented Mar 8, 2018

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 8, 2018
@ansibot ansibot merged commit 2a09714 into ansible:devel Mar 8, 2018
@arendej
Copy link
Contributor Author

arendej commented Mar 8, 2018 •
edited

This is a documentation fix that I believe should backport into prior versions. It's relevant at least in 2.4+
@giuseppe @krsacme

@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. cloud docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arendej @ansibot @giuseppe @krsacme