Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdirect_file: Fixing lack of failure when uploaded source is invalid #37461

Merged
merged 1 commit into from Apr 4, 2018
Merged

vdirect_file: Fixing lack of failure when uploaded source is invalid #37461

merged 1 commit into from Apr 4, 2018

Conversation

evgenyfedoruk
Copy link
Contributor

SUMMARY

Fixing lack of failure when uploaded source is invalid
Checking the response status for 400 and throwing exception.
Unit tests updated.

Fixes #37406

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vdirect_file

ANSIBLE VERSION
ansible 2.4.3.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/share/my_modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2018

@evgenyfedoruk this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

test/units/modules/network/radware/test_vdirect_file.py:109:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'KeyError was not thrown for missing parameter'
test/units/modules/network/radware/test_vdirect_file.py:137:16: redundant-unittest-assert Redundant use of assertFalse with constant value 'IOException was not thrown for missing file'

click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 15, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2018

@evgenyfedoruk this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 15, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2018

@evgenyfedoruk this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@evgenyfedoruk
Fixing lack of failure when uploaded source is invalid
a8ef37a 
Checking the response status for 400 and throwing exception.
Unit tests updated.

Fixes ansible#37406
@ansibot
Copy link
Contributor

ansibot commented Mar 15, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. test This PR relates to tests. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Mar 15, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 15, 2018
@gundalow gundalow changed the title Fixing lack of failure when uploaded source is invalid vdirect_file: Fixing lack of failure when uploaded source is invalid Mar 16, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 24, 2018
@calfonso calfonso merged commit 5e99030 into ansible:devel Apr 4, 2018
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@evgenyfedoruk @ryancurrah
Fixing lack of failure when uploaded source is invalid (ansible#37461)
815a116 
Checking the response status for 400 and throwing exception.
Unit tests updated.

Fixes ansible#37406
@gundalow gundalow moved this from To do to Need CP into 2.5.1 in zzz NOT USED: Networking Bugs Apr 17, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request May 16, 2018
@evgenyfedoruk @gundalow
Fixing lack of failure when uploaded source is invalid (ansible#37461)
ee51128 
Checking the response status for 400 and throwing exception.
Unit tests updated.

Fixes ansible#37406
(cherry picked from commit 5e99030)
@gundalow gundalow mentioned this pull request May 16, 2018
Merged
@gundalow gundalow moved this from Need CP into 2.5.3 to Done in zzz NOT USED: Networking Bugs May 16, 2018
gundalow added a commit that referenced this pull request May 16, 2018
@gundalow
Backport/2.5/37461 (#40252)
f791ec2 
* Fixing lack of failure when uploaded source is invalid (#37461)

Checking the response status for 400 and throwing exception.
Unit tests updated.

Fixes #37406
(cherry picked from commit 5e99030)

* changelog
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@evgenyfedoruk @ilicmilan
Fixing lack of failure when uploaded source is invalid (ansible#37461)
a22efcd 
Checking the response status for 400 and throwing exception.
Unit tests updated.

Fixes ansible#37406
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vdirect_file module does not notify the user about invalid state of uploaded source
4 participants
@evgenyfedoruk @ansibot @calfonso @samdoran