Add Jinja2 tests for testing types #37517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
feature
dagwieers
force-pushed
the
jinja2-type-tests
branch
8 times, most recently
from
32c5efd
to
df36426
Compare
mkrizek
removed
the
needs_triage
bcoca
approved these changes
Mar 16, 2018
ansibot
added
support:community
dagwieers
force-pushed
the
jinja2-type-tests
branch
from
df36426
to
66ccd11
Compare
dagwieers
force-pushed
the
jinja2-type-tests
branch
4 times, most recently
from
459373b
to
9fc9cd1
Compare
ansibot
removed
the
needs_revision
ansibot
added
the
needs_revision
dagwieers
force-pushed
the
jinja2-type-tests
branch
2 times, most recently
from
27375cc
to
571fa20
Compare
felixfontein
added a commit
to felixfontein/ansible
that referenced
this pull request
Jun 1, 2018
webknjaz
reviewed
Jun 1, 2018
lib/ansible/plugins/test/core.py
Outdated
|
|
||
|
|
||
| # NOTE: The existing Jinja2 'sequence' test matches strings and dictionaries | ||
| def test_list(value): |
There was a problem hiding this comment.
Now that #39924 has been merged into devel you can:
from functools import partial
from ansible.module_utils.common.collections import is_sequence
test_list = partial(is_sequence, include_strings=False)There was a problem hiding this comment.
I am not impressed, sorry. I don't think this will make it easier to upstream. I don't need an Ansible-only solution.
There was a problem hiding this comment.
I'm not talking about upstream. This is about this PR, which currently doesn't need to have duplicate code, like one in devel.
acozine
pushed a commit
that referenced
this pull request
Jun 28, 2018
) * Also marking non-string defaults. * Adding list filter from #37517 to plugin_formatter. * Simplifying list test. * Redistribute imports
acozine
pushed a commit
to acozine/ansible
that referenced
this pull request
Jul 10, 2018
…ible#40212) * Also marking non-string defaults. * Adding list filter from ansible#37517 to plugin_formatter. * Simplifying list test. * Redistribute imports (cherry picked from commit 0752dc1)
mattclay
pushed a commit
that referenced
this pull request
Jul 17, 2018
#42075) * Documentation: show non-string non-iterable defaults for choices (#40212) * Also marking non-string defaults. * Adding list filter from #37517 to plugin_formatter. * Simplifying list test. * Redistribute imports (cherry picked from commit 0752dc1) * for 2.6 compatibility, removes dependency on collections.py, take two * fix blank line error
dagwieers
force-pushed
the
jinja2-type-tests
branch
from
dfbb592
to
a8ac047
Compare
ansibot
removed
needs_rebase
This comment has been minimized.
This comment has been minimized.
dagwieers
force-pushed
the
jinja2-type-tests
branch
from
a8ac047
to
834dc91
Compare
mattclay
reviewed
Jul 25, 2018
| @@ -0,0 +1 @@ | |||
| shippable/posix/ci/group1 | |||
So Jinja2 only has tests for testing string types, or iterable types, which is quite limiting. If you need to test a boolean value in Jinja2 the only option is to test it is not a string and convert it to a string and compare it to 'True' or 'False'. So these tests are essential constructs in playbooks and templates. This PR includes integration tests to validate Jinja2 behaviour.
dagwieers
force-pushed
the
jinja2-type-tests
branch
from
834dc91
to
43e716b
Compare
ansibot
removed
ci_verified
webknjaz
requested changes
Jul 31, 2018
|
|
||
|
|
||
| # NOTE: The existing Jinja2 'sequence' test also matches strings and dictionaries | ||
| def test_list(value): |
There was a problem hiding this comment.
This code is already available in ansible.module_utils.common.collections.is_sequence for broader use.
So please follow earlier suggestion to reuse it: #37517 (comment)
ansibot
added
the
needs_revision
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
|
So instead of duplicating tests to allow older versions of Jinja2 to work the same, but mask changes/implementation details on newer ones, we've opted to add a 'jinja2' collection with these kind of tests/filters that are missing from older versions. temporarily at https://galaxy.ansible.com/sivel/jinja2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
So Jinja2 only has tests for testing string types, or iterable types,
which is quite limiting. If you need to test a boolean value in Jinja2
the
onlyoption is to test it is not a string and convert it to a stringand compare it to 'True' or 'False'.
So these tests are essential constructs in playbooks and templates.
This includes tests for:
So you can simply do things like:
or
Just like you already can do
and
See the included integration tests for a complete explanation of what Jinja2 already can do, and how this is insufficient in some cases where this would be useful.
This is related to #37514
ISSUE TYPE
COMPONENT NAME
Jinja2 core tests
ANSIBLE VERSION
v2.6