Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure we are checking text for text #37605

Closed
wants to merge 1 commit into from
Closed

ensure we are checking text for text #37605

wants to merge 1 commit into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 19, 2018

SUMMARY

fixes #36962

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-pull

ANSIBLE VERSION
2.4-2.6

@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Mar 19, 2018
@bcoca bcoca requested a review from abadger March 19, 2018 16:07
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 19, 2018
@abadger
Copy link
Contributor

abadger commented Mar 19, 2018

Going to use the version in #37606

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 19, 2018
@bcoca bcoca closed this Mar 19, 2018
@bcoca bcoca deleted the pull_changed_fix branch March 19, 2018 17:29
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 22, 2018
@nitzmahone nitzmahone removed this from To Do in 2.5.x blocker list Apr 18, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix string/binary encoding issue in pull.py
4 participants
@bcoca @abadger @samdoran @ansibot