Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter invalid args from actions #37611

Closed
wants to merge 2 commits into from
Closed

filter invalid args from actions #37611

wants to merge 2 commits into from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 19, 2018

SUMMARY

creates general facility and fixes template specfically

fixes #37238

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

action plugins

ANSIBLE VERSION
2.4-2.6

@bcoca
filter invalid args from actions
2999074 
creates general facility and fixes template specfically

fixes ansible#37238
@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Mar 19, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 19, 2018
@abadger
Copy link
Contributor

abadger commented Mar 19, 2018

This is wrong. (1) It needs to be a whitelist. (2) If we're serious about moving argspec to the action modules in the future, we do not want to create a generic facility that will be in conflict with that.

CC @nitzmahone

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 19, 2018
@sivel
Copy link
Member

sivel commented Mar 19, 2018

I am in agreement with @abadger

We should do a whitelist. When we do the basic.py separation (based on work I have done so far) we will get arg_spec validation functionality in action plugins, since we can use "that" new class independently of a module.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 22, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 30, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 7, 2018
@nitzmahone nitzmahone moved this from To Do to 2.5.2 holding in 2.5.x blocker list Apr 18, 2018
@bcoca bcoca moved this from 2.5.2 holding to To Do in 2.5.x blocker list Apr 27, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 17, 2018
@maxamillion
Copy link
Contributor

@bcoca @sivel any update here?

@bcoca bcoca removed this from To Do in 2.5.x blocker list May 30, 2018
@bcoca bcoca mentioned this pull request Aug 28, 2018
Closed
@samdoran
Copy link
Contributor

samdoran commented Aug 29, 2018 •
edited

Superseded by #44779

@bcoca
Copy link
Member Author

bcoca commented Aug 29, 2018

@samdoran related but not the same

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 30, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 15, 2018
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:community This issue/PR relates to code supported by the Ansible community. labels Nov 26, 2018
@relrod relrod closed this Apr 3, 2020
@ansible ansible locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remote_src=true with template causes Module (template) is missing interpreter line
7 participants
@bcoca @abadger @sivel @maxamillion @samdoran @relrod @ansibot