Fix edgeos_config: {backup: yes} #37619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qalthos
commented
Mar 19, 2018
| @@ -56,7 +56,7 @@ def run(self, tmp=None, task_vars=None): | |||
|
|
|||
| # strip out any keys that have two leading and two trailing | |||
| # underscore characters | |||
| for key in result.keys(): | |||
There was a problem hiding this comment.
Python 3 dictionary views are not copies, so you can't modify over them
Qalthos
commented
Mar 19, 2018
| from __future__ import (absolute_import, division, print_function) | ||
| __metaclass__ = type | ||
|
|
||
| from ansible.plugins.action.vyos_config import ActionModule |
There was a problem hiding this comment.
This is awful, but it works. Will replace with proper copy.
ansibot
added
bug
Qalthos
removed
the
needs_triage
ansibot
added
python3
and removed
needs_revision
|
Python3 fixes herein Look good to me. +1 on that portion of the changes. |
samdoran
approved these changes
Mar 21, 2018
samdoran
pushed a commit
to samdoran/ansible
that referenced
this pull request
Mar 21, 2018
* Fix edgeos_config: {backup: yes}
* Add actual plugin copy
(cherry picked from commit 6aed74a)
samdoran
added a commit
that referenced
this pull request
Apr 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
backup: yesdoes not do the right thing inedgeos_commandbecause there is no action plugin to do the actual backupAlso copy some Python 3 fixes back to vyos_config's action plugin
ISSUE TYPE
COMPONENT NAME
edgeos_config
ANSIBLE VERSION