cs_vpc_offering: listVPCOffering API returns any matching names

[dpassante]

SUMMARY

Make an explicit comparison between args['name'] and the result of listVPCOfferings API.

In some cases, get_vpc_offering() returns a bad VPC Offering since the Cloudstack listVPCOffering API returns a list of all VPC offerings that are matching "%name%" argument.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/cloud/cloudstack/cs_vpc_offering.py

ANSIBLE VERSION

 $ ansible --version
ansible 2.6.0 (listVPCOffering_multiple_match 9f5ac8367e) last updated 2018/03/22 15:13:46 (GMT +200)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/dpassante/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /mnt/filer/Github/ansible/lib/ansible
  executable location = /mnt/filer/Github/ansible/bin/ansible
  python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]

ADDITIONAL INFORMATION

As get_vpc_offering() returns the first offering that match the name '%test%', running this playbook twice is failing:

---
- name: listVPCOffering_multiple_match
  hosts: localhost
  tasks:
  - name: test
    cs_vpc_offering:
      name: "test"
      display_text: "test"
      supported_services: [ Dns, Dhcp ]

  - name: test1
    cs_vpc_offering:
      name: "test1"
      display_text: "test1"
      supported_services: [ Dns, Dhcp ]

[ansibot]

cc @resmo
click here for bot help

[resmo]

any reason why we should not use a simplified loop?

for vpc_offer in vo['vpcoffering']:

[dpassante]

Indeed, a simplified loop do the same.

[resmo]

Thanks for this fix, are you aware of other queries (is this a general thing?) which have the same behaviour?

[resmo]

needs_info

[dpassante]

From what I understand from the Cloudstack code, the following queries have the same behaviour:

• Configurations (I was about to submit a fix)
• Counters
• PhysicalNetwork (PR Add new CloudStack module cs_physical_network #25647 should be affected)
• OsCategories

[dpassante]

cs_configuration always returns 'Changed' when name=workers for example.

[resmo]

I created a separate issue #37824

[resmo]

shipit

[resmo]

cherry-picked for 2.5.1 by #37832