Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't split line when no version available for plugin #37907

Merged
merged 2 commits into from
May 3, 2018
Merged

Don't split line when no version available for plugin #37907

merged 2 commits into from
May 3, 2018

Conversation

seuf
Copy link
Contributor

@seuf seuf commented Mar 26, 2018

SUMMARY

Fix grafana plugin version fetching : Don't split line when no version available in grafana plugin list.
Related Issue : #37886

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

grafana_plugin module

ANSIBLE VERSION
ansible 2.4.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Dec 11 2017, 16:08:01) [GCC 7.2.1 20170915 (Red Hat 7.2.1-2)]

@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2018

cc @tsalle
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 26, 2018
@seuf
Copy link
Contributor Author

seuf commented Mar 26, 2018

shipit

@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Mar 27, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 4, 2018
@seuf
Copy link
Contributor Author

seuf commented Apr 9, 2018

This PR fix a grafana plugin ansible 2.5 module.
Could you review it please ?

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 9, 2018
@seuf seuf mentioned this pull request Apr 9, 2018
Merged
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 18, 2018
@seuf
Copy link
Contributor Author

seuf commented May 3, 2018

Is it possible to review / merge it ? cc @bcoca

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 3, 2018
@bcoca bcoca merged commit cc477ba into ansible:devel May 3, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@seuf
Don't split line when no version available for plugin (ansible#37907)
622ff6f 
* Don't split line when no version available for plugin

* Fixed author github account
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@seuf
Don't split line when no version available for plugin (ansible#37907)
1140530 
* Don't split line when no version available for plugin

* Fixed author github account
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@seuf
Don't split line when no version available for plugin (ansible#37907)
65e8056 
* Don't split line when no version available for plugin

* Fixed author github account
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@seuf @tonal
Don't split line when no version available for plugin (ansible#37907)
4d2db65 
* Don't split line when no version available for plugin

* Fixed author github account
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@seuf
Don't split line when no version available for plugin (ansible#37907)
306805e 
* Don't split line when no version available for plugin

* Fixed author github account
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@seuf
Don't split line when no version available for plugin (ansible#37907)
4898bbd 
* Don't split line when no version available for plugin

* Fixed author github account
@seuf seuf deleted the grafana_plugin_fix_unknown_version branch July 18, 2018 08:54
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@seuf @ilicmilan
Don't split line when no version available for plugin (ansible#37907)
573dc77 
* Don't split line when no version available for plugin

* Fixed author github account
@ansible ansible locked and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seuf @ansibot @ryansb @bcoca