Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SGs in default VPCs get default egress rule #38018

Merged
merged 1 commit into from Mar 28, 2018
Merged

Ensure SGs in default VPCs get default egress rule #38018

merged 1 commit into from Mar 28, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

SGs created when a VPC ID was not specified would not necessarily
get the default egress rule, even when no explicit egress rules
were set.

Add some checks for egress rules in results from existing tests

Fixes #37963

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_group

ANSIBLE VERSION
ansible 2.6.0 (devel 0ee275ca64) last updated 2018/03/28 11:18:16 (GMT +1000)
  config file = None
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]
ADDITIONAL INFORMATION

Should be backported to 2.5

Ensure SGs in default VPCs get default egress rule
d98f0a0 
SGs created when a VPC ID was not specified would not necessarily
get the default egress rule, even when no explicit egress rules
were set.

Add some checks for egress rules in results from existing tests
@willthames willthames mentioned this pull request Mar 28, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Mar 28, 2018

cc @adq
click here for bot help

@ansibot ansibot added aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 28, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 28, 2018
@ryansb ryansb merged commit 98b29f8 into ansible:devel Mar 28, 2018
s-hertel pushed a commit to s-hertel/ansible that referenced this pull request Mar 28, 2018
@willthames
[cloud]Ensure SGs in default VPCs get default egress rule (ansible#38018
4a8e875 
)

SGs created when a VPC ID was not specified would not necessarily
get the default egress rule, even when no explicit egress rules
were set.

Add some checks for egress rules in results from existing tests

(cherry picked from commit 98b29f8)
s-hertel pushed a commit that referenced this pull request Mar 28, 2018
@willthames
[cloud]Ensure SGs in default VPCs get default egress rule (#38018)
60e7aa0 
SGs created when a VPC ID was not specified would not necessarily
get the default egress rule, even when no explicit egress rules
were set.

Add some checks for egress rules in results from existing tests

(cherry picked from commit 98b29f8)
@s-hertel
Copy link
Contributor

Backported to 2.5 in 60e7aa0. Thanks @willthames!

ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@willthames @ryancurrah
[cloud]Ensure SGs in default VPCs get default egress rule (ansible#38018
d9ce316 
)

SGs created when a VPC ID was not specified would not necessarily
get the default egress rule, even when no explicit egress rules
were set.

Add some checks for egress rules in results from existing tests
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a security group with none rules_egress doesn't create default all-out rule
4 participants
@willthames @ansibot @s-hertel @ryansb