New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables lock issue #38106

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@akamac

akamac commented Mar 29, 2018

SUMMARY

When adding multiple rules in a loop it is possible to get lock error.
-w switch fixes this:

--wait -w [seconds] wait for the xtables lock

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iptables module

ANSIBLE VERSION

ansible 2.6.0 (fix c1aac04495)

ADDITIONAL INFORMATION

Added -w as default parameter.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 29, 2018

@sebastiendarocha

This comment has been minimized.

Contributor

sebastiendarocha commented Mar 29, 2018

Actually, older versions of iptables are incompatible with this option. I think Debian 7 is in this case.

I agree with you, this option important. Maybe we could check the version of iptables, or try without "-w" if the command fails ?

@ansibot ansibot removed the needs_triage label Mar 29, 2018

@ansibot ansibot added the stale_ci label Apr 6, 2018

@akamac akamac force-pushed the akamac:iptables-wait branch from 03c843d Apr 6, 2018

@ansibot ansibot removed the stale_ci label Apr 6, 2018

Alexey Miasoedov

@akamac akamac force-pushed the akamac:iptables-wait branch to 6760b29 Apr 6, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 6, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/system/iptables.py:459:4: using-constant-test Using a conditional statement with a constant value
lib/ansible/modules/system/iptables.py:472:17: undefined-variable Undefined variable 'module'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ImportError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ModuleNotFoundError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ModuleNotFoundError: No module named 'pkg_resources'

click here for bot help

@ansibot ansibot added the stale_ci label Apr 14, 2018

@mattclay

This comment has been minimized.

Member

mattclay commented Apr 26, 2018

@akamac

This comment has been minimized.

akamac commented May 10, 2018

@mattclay Seems to be unit tests should be fixed to reflect the new -w switch.

@mattclay

This comment has been minimized.

Member

mattclay commented May 10, 2018

@akamac Yes, the unit tests will need to be updated as part of this PR.

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 18, 2018

@akamac this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 18, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/system/iptables.py:476:4: using-constant-test Using a conditional statement with a constant value
lib/ansible/modules/system/iptables.py:489:17: undefined-variable Undefined variable 'module'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ImportError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ModuleNotFoundError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ModuleNotFoundError: No module named 'pkg_resources'

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment