iptables lock issue

[akamac]

SUMMARY

When adding multiple rules in a loop it is possible to get lock error.
-w switch fixes this:

--wait -w [seconds] wait for the xtables lock

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

iptables module

ANSIBLE VERSION

ansible 2.6.0 (fix c1aac04495)

ADDITIONAL INFORMATION

Added -w as default parameter.

[ansibot]

cc @LinusU @sebastiendarocha
click here for bot help

[sebastiendarocha]

Actually, older versions of iptables are incompatible with this option. I think Debian 7 is in this case.

I agree with you, this option important. Maybe we could check the version of iptables, or try without "-w" if the command fails ?

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/system/iptables.py:459:4: using-constant-test Using a conditional statement with a constant value
lib/ansible/modules/system/iptables.py:472:17: undefined-variable Undefined variable 'module'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ImportError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ModuleNotFoundError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:348:0: ModuleNotFoundError: No module named 'pkg_resources'

click here for bot help

[mattclay]

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/60448/3/tests

[akamac]

@mattclay Seems to be unit tests should be fixed to reflect the new -w switch.

[mattclay]

@akamac Yes, the unit tests will need to be updated as part of this PR.

[ansibot]

@akamac this PR contains the following merge commits:

• c0ec0df

Please rebase your branch to remove these commits.

click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/system/iptables.py:476:4: using-constant-test Using a conditional statement with a constant value
lib/ansible/modules/system/iptables.py:489:17: undefined-variable Undefined variable 'module'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ImportError: No module named pkg_resources

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ImportError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ModuleNotFoundError: No module named 'pkg_resources'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:365:0: ModuleNotFoundError: No module named 'pkg_resources'

click here for bot help

[bcoca]

consider making this a module option, I would not accept it in it's current state as it is both backwards incompatible with older iptables and changes the default behaviour of the module.

needs_info

[Akasurde]

Closing in favor of #47877