fix for security group description crash #38108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #37658 |
ansibot
added
azure
bug
|
Fixes #37658 |
ansibot
removed
the
needs_triage
|
shipit |
ansibot
added
shipit
|
LGTM |
|
@jborean93 could you check this? |
yuwzho
reviewed
Apr 10, 2018
| @@ -400,7 +400,7 @@ def compare_rules(r, rule): | |||
| matched = True | |||
| if rule.get('description', None) != r['description']: | |||
| changed = True | |||
| r['description'] = rule['description'] | |||
| r['description'] = rule.get('description', None) | |||
| if rule['protocol'] != r['protocol']: | |||
There was a problem hiding this comment.
will make the protocol also positional args?
There was a problem hiding this comment.
is there any other parameter need same fix so that user will be able to update security group eventually
There was a problem hiding this comment.
other params will be always there afaik
yungezz
approved these changes
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
tonal
pushed a commit
to tonal/ansible
that referenced
this pull request
May 15, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a crash when existing description is not empty, and description not specified in task.
ISSUE TYPE
COMPONENT NAME
azure_rm_securitygroup
ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION