Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Letsencrypt: improving documentation on second run #38135

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Letsencrypt: improving documentation on second run #38135

merged 1 commit into from
Mar 31, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

As @apple4ever noted in #37884, the module's documentation is unclear w.r.t. that the second run of the letsencrypt module needs the data provided by the first run. (This is a result of adding ACME v2 support, and that the old behavior could cause certificates to be issued more than once.)

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

letsencrypt

ANSIBLE VERSION

2.5.0

@ansibot
Copy link
Contributor

ansibot commented Mar 30, 2018

cc @mgruener @resmo
click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 30, 2018
@felixfontein felixfontein mentioned this pull request Mar 30, 2018
Closed
@apple4ever
Copy link
Contributor

This meets what I would expect reading it for the first time. I like it!

resmo
resmo approved these changes Mar 31, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. labels Mar 31, 2018
@felixfontein
Copy link
Contributor Author

@apple4ever: good, thanks for taking a look!
@resmo: I've rebased the PR; that was needed as the places modified by this PR and #38137 were too close.

@felixfontein
Copy link
Contributor Author

@resmo: this should also go into the stable-2.5 branch; should I create a PR for that (once its merged), or do you want to do this?

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 31, 2018
@resmo
Copy link
Contributor

resmo commented Mar 31, 2018

@felixfontein perfect.

I prefer if you do the PRs against stable-2.5, if you create a PR, it is okay to have more than one cherry-picks in the PR.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 31, 2018
@ansibot ansibot merged commit 93fc99c into ansible:devel Mar 31, 2018
@felixfontein felixfontein deleted the letsencrypt-improve-run-doc branch March 31, 2018 14:21
felixfontein added a commit to felixfontein/ansible that referenced this pull request Mar 31, 2018
@felixfontein
Making clearer that the module has to be executed twice, and that the…
ed94b5e 
… second run needs the data of the first (ansible#37884). (ansible#38135)

(cherry picked from commit 93fc99c)
@felixfontein felixfontein mentioned this pull request Mar 31, 2018
Merged
@felixfontein
Copy link
Contributor Author

@resmo: I created a PR against stable-2.5 (#38160), and this time with git cherry-pick -x :)

resmo pushed a commit that referenced this pull request Mar 31, 2018
@felixfontein @resmo
letsencrypt: doc: Making clearer that the module has to be executed t…
112f577 
…wice, and that the second run needs the data of the first (#37884). (#38135) (#38160)

(cherry picked from commit 93fc99c)
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@felixfontein @ryancurrah
Making clearer that the module has to be executed twice, and that the…
de0ab0e 
… second run needs the data of the first (ansible#37884). (ansible#38135)
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@felixfontein @ilicmilan
Making clearer that the module has to be executed twice, and that the…
121febf 
… second run needs the data of the first (ansible#37884). (ansible#38135)
@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. crypto Crypto community (ACME, openssl, letsencrypt) docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@felixfontein @ansibot @apple4ever @resmo @dagwieers