Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue when netconf would report ios is not supported #38155

Merged
merged 2 commits into from Apr 3, 2018
Merged

fixes issue when netconf would report ios is not supported #38155

merged 2 commits into from Apr 3, 2018

Conversation

privateip
Copy link
Contributor

This change now will map ansible_network_os=ios to the correct netconf
plugin implementation. This will resolve an error where the netconf
connection plugin will report that ios is unsupported.

This should be cherry-picked to stable-2.5

fixes issue when netconf would report ios is not supported
7054b11 
This change now will map ansible_network_os=ios to the correct netconf
plugin implementation.  This will resolve an error where the netconf
connection plugin will report that ios is unsupported.
@privateip privateip requested a review from Qalthos March 30, 2018 20:16
@ansibot
Copy link
Contributor

ansibot commented Mar 30, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/connection/netconf.py:271:12: unreachable Unreachable code

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 30, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 30, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 31, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 31, 2018
@Qalthos Qalthos merged commit 91a748e into ansible:devel Apr 3, 2018
Qalthos pushed a commit to Qalthos/ansible that referenced this pull request Apr 3, 2018
@privateip @Qalthos
fixes issue when netconf would report ios is not supported (ansible#3…
357ec3b 
…8155)

* fixes issue when netconf would report ios is not supported

This change now will map ansible_network_os=ios to the correct netconf
plugin implementation.  This will resolve an error where the netconf
connection plugin will report that ios is unsupported.

(cherry picked from commit 91a748e)
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@privateip @ryancurrah
fixes issue when netconf would report ios is not supported (ansible#3…
716025a 
…8155)

* fixes issue when netconf would report ios is not supported

This change now will map ansible_network_os=ios to the correct netconf
plugin implementation.  This will resolve an error where the netconf
connection plugin will report that ios is unsupported.
Qalthos added a commit that referenced this pull request Apr 5, 2018
@Qalthos
fixes issue when netconf would report ios is not supported (#38155) (#…
6356633 
…38240)

* fixes issue when netconf would report ios is not supported

This change now will map ansible_network_os=ios to the correct netconf
plugin implementation.  This will resolve an error where the netconf
connection plugin will report that ios is unsupported.

(cherry picked from commit 91a748e)
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@privateip @ilicmilan
fixes issue when netconf would report ios is not supported (ansible#3…
a19e502 
…8155)

* fixes issue when netconf would report ios is not supported

This change now will map ansible_network_os=ios to the correct netconf
plugin implementation.  This will resolve an error where the netconf
connection plugin will report that ios is unsupported.
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
cisco Cisco technologies ios Cisco IOS community networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@privateip @ansibot @ganeshrn @dagwieers @Qalthos