ignore version when deciding callback loading #38281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code already defaulted to load the callback if the properties are not present there was no need for us to also check the version fixes ansible#38270
ansibot
added
bug
ansibot
added
the
needs_revision
bcoca
removed
the
needs_revision
bcoca
added a commit
to bcoca/ansible
that referenced
this pull request
Apr 27, 2018
* ignore version when deciding callback loading The code already defaulted to load the callback if the properties are not present there was no need for us to also check the version fixes ansible#38270 * fix error msg on set optoins to use correct name (cherry picked from commit 1850bb7)
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* ignore version when deciding callback loading The code already defaulted to load the callback if the properties are not present there was no need for us to also check the version fixes ansible#38270 * fix error msg on set optoins to use correct name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The code already defaulted to load the callback if the properties are not present
there was no need for us to also check the version
fixes #38270
related #38266, fixes the specific plugin by updating the version, but this PR makes it so that it isn't required anymore
ISSUE TYPE
COMPONENT NAME
tqm
ANSIBLE VERSION