Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove space between datastore and path #38507

Closed
wants to merge 1 commit into from
Closed

remove space between datastore and path #38507

wants to merge 1 commit into from

Conversation

brystro
Copy link

@brystro brystro commented Apr 10, 2018

if there is a space between the datastore & path the guest will not boot off the iso image
+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_guest.py

ANSIBLE VERSION
2.6devel

<!--- Your description here -->
if there is a space between the datastore & path the guest will not boot off the iso image
+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2018

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Apr 10, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Apr 10, 2018
@ansibot ansibot added the docs This issue/PR relates to or includes documentation. label Apr 10, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 18, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Apr 20, 2018
@ansibot
Copy link
Contributor

ansibot commented May 6, 2018

@pdellaert
Copy link
Contributor

How did you determine this? Because i've done this multiple times with a space and have never run into any issue...
What versions of ESXi and vCenter are you running?

@Akasurde
Copy link
Member

Akasurde commented May 7, 2018

needs_info

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 7, 2018
@brystro
Copy link
Author

brystro commented May 10, 2018

esxi 6.0, vcenter 6.0
I am passing a (var) datastore path to an iso as "[OS] Linux/ubuntu-16.iso" as iso_path in the cdrom object, i.e:

tasks:
  -- name: create vm
       vmware_guest:
     (details removed for brevity)
     cdrom:
       type: "iso"
       iso_path: "{{ iso_path }}"

it only gets the [OS] part unless I remove the space between [OS] and Linux/ubuntu-16.iso

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_info This issue requires further information. Please answer any outstanding questions. labels May 10, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 18, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 6, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 14, 2018
@gundalow
Copy link
Contributor

@brystro @pdellaert Any thoughts on this?

@pdellaert
Copy link
Contributor

@brystro, that is strange, because i have something similar and it works every time...:

    cdrom:
      type: iso
      iso_path: "{{ vcenter_iso_path }}/{{ name }}-cidata.iso"

where {{ vcenter_iso_path }} equals [nfs] cloud-init-isos, and it works fine.

Have you tested doing just a string, not a variable and see what that gives? (also made sure there is no double space).

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 4, 2018
@acozine
Copy link
Contributor

acozine commented Nov 6, 2018

@brystro are you still having trouble with the space between the datastore and the path? If we don't hear more details, we'll close this PR.

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

cc @ckotte
click here for bot help

@acozine
Copy link
Contributor

acozine commented Dec 21, 2018

No new is good news, I hope. Since we haven't seen confirmation that the space is still causing problems, and we have seen confirmation that tasks can work the way the documentation suggests, I'm going to close this PR. @brystro please open an issue (or a new PR) if this is still a problem.

@acozine acozine closed this Dec 21, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants