Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum protocol versions #38644

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Update minimum protocol versions #38644

merged 1 commit into from
Apr 18, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

As per docs, the current set of values is

'SSLv3'|'TLSv1'|'TLSv1_2016'|'TLSv1.1_2016'|'TLSv1.2_2018'

Fixes #38642

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudfront_distribution

ANSIBLE VERSION
ansible 2.6.0 (devel c9fb054bc8) last updated 2018/04/12 10:55:24 (GMT +1000)
  config file = None
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

Update minimum protocol versions
39638b0 
As per docs, the current set of values is

```
'SSLv3'|'TLSv1'|'TLSv1_2016'|'TLSv1.1_2016'|'TLSv1.2_2018'
```

Fixes ansible#38642
@willthames
Copy link
Contributor Author

Candidate for backporting to 2.5

@willthames willthames mentioned this pull request Apr 12, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Apr 12, 2018

cc @wilvk
click here for bot help

@ansibot ansibot added aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 12, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Apr 12, 2018
@stevenscg
Copy link
Contributor

This checks OK. Thanks!

@s-hertel s-hertel merged commit 6b97034 into ansible:devel Apr 18, 2018
@s-hertel
Copy link
Contributor

@willthames +1 to backport this

willthames added a commit to willthames/ansible that referenced this pull request Apr 19, 2018
@willthames
[AWS cloudfront_distribution] Update minimum protocol versions (ansib…
846b405 
…le#38644)

As per docs, the current set of values is

```
'SSLv3'|'TLSv1'|'TLSv1_2016'|'TLSv1.1_2016'|'TLSv1.2_2018'
```

Fixes ansible#38642

(cherry picked from commit 6b97034)
@willthames willthames mentioned this pull request Apr 19, 2018
Merged
s-hertel pushed a commit that referenced this pull request Apr 19, 2018
@willthames @s-hertel
[AWS cloudfront_distribution] Update minimum protocol versions (#38644)…
2b98513 
… (#38990)

As per docs, the current set of values is

```
'SSLv3'|'TLSv1'|'TLSv1_2016'|'TLSv1.1_2016'|'TLSv1.2_2018'
```

Fixes #38642

(cherry picked from commit 6b97034)
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@willthames @ilicmilan
[AWS cloudfront_distribution] Update minimum protocol versions (ansib…
99c08b9 
…le#38644)

As per docs, the current set of values is

```
'SSLv3'|'TLSv1'|'TLSv1_2016'|'TLSv1.1_2016'|'TLSv1.2_2018'
```

Fixes ansible#38642
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudfront_distribution: Update valid minimum_protocol_versions
5 participants
@willthames @ansibot @stevenscg @s-hertel @jborean93