Fix in eos get_config cliconf api #38682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If format is passed as None to get_config api, wrong command is genereted ie. `show running-configuration | None | section interface`. Add format type in command only if format value is either not `text` or `None`.
ansibot
added
bug
mkrizek
removed
the
needs_triage
rcarrillocruz
approved these changes
Apr 13, 2018
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Apr 13, 2018
If format is passed as None to get_config api, wrong command is genereted ie. `show running-configuration | None | section interface`. Add format type in command only if format value is either not `text` or `None`. (cherry picked from commit 88662d0) Update changelog
ganeshrn
added a commit
that referenced
this pull request
Apr 13, 2018
If format is passed as None to get_config api, wrong command is genereted ie. `show running-configuration | None | section interface`. Add format type in command only if format value is either not `text` or `None`. (cherry picked from commit 88662d0) Update changelog
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
If format is passed as None to get_config api, wrong command is genereted ie. `show running-configuration | None | section interface`. Add format type in command only if format value is either not `text` or `None`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If format is passed as None to get_config api, wrong command is
genereted ie.
show running-configuration | None | section interface.Add format type in command only if format value is either not
textor not
None.ISSUE TYPE
COMPONENT NAME
plugins/cliconf/eos.py
ANSIBLE VERSION
ADDITIONAL INFORMATION