Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated "instead" word #38800

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Remove duplicated "instead" word #38800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a07524
Remove duplicated "instead" word
bocharsky-bw Apr 16, 2018
02c4aa7
Actually fix the message
bocharsky-bw Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ansible/template/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def tests_as_filters_warning(name, func):
@wraps(func)
def wrapper(*args, **kwargs):
display.deprecated(
'Using tests as filters is deprecated. Instead of using `result|%(name)s` instead use '
'Using tests as filters is deprecated. Instead of using `result|%(name)s` use '
'`result is %(name)s`' % dict(name=name),
version='2.9'
)
Expand Down
4 changes: 2 additions & 2 deletions test/units/template/test_tests_as_filters_warning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ def test_tests_as_filters_warning(mocker):
# Call successful test, ensure the message is correct
filters['successful']({})
display.deprecated.assert_called_once_with(
'Using tests as filters is deprecated. Instead of using `result|successful` instead use `result is successful`', version='2.9'
'Using tests as filters is deprecated. Instead of using `result|successful` use `result is successful`', version='2.9'
)

# Call success test, ensure the message is correct
display.deprecated.reset_mock()
filters['success']({})
display.deprecated.assert_called_once_with(
'Using tests as filters is deprecated. Instead of using `result|success` instead use `result is success`', version='2.9'
'Using tests as filters is deprecated. Instead of using `result|success` use `result is success`', version='2.9'
)

# Call bool filter, ensure no deprecation message was displayed
Expand Down