-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update info on python support #38855
Conversation
/cc @acozine |
The test
The test
|
.. note:: | ||
|
||
If you have Python 3 as a default Python slot on your Gentoo nodes (default setting), then you | ||
must set ``ansible_python_interpreter = /usr/bin/python2`` in your group or inventory variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentoo defaults to 3.4, so we might want to leave the note but change the content, but probably make it 'some distros' as it is not the only one.
this in inventory like so:: | ||
|
||
solaris1 ansible_shell_executable=/usr/xpg4/bin/sh | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10 on adding solaris notes
5720514
to
9d9784f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the Common Platform section. That addresses issue #21594.
Running on Solaris | ||
------------------ | ||
|
||
Some Solaris machines use a non-POSIX shell by default. This can cause trouble for things such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
"By default, some Solaris machines run a non-POSIX shell, which does not correctly expand the default tmp directory Ansible uses ( ~/.ansible/tmp
). If you see module failures on Solaris machines, this is likely the problem. There are several workarounds:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is only on certain modules, then I'd say "If you see failures on the x and/or y modules on Solaris machines"
@@ -200,6 +200,8 @@ several workarounds: | |||
|
|||
solaris1 ansible_shell_executable=/usr/xpg4/bin/sh | |||
|
|||
(bash, ksh, and zsh should also be POSIX compatible if you have any of those installed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for adding specific examples
Ansible 2.2 introduces a tech preview of support for Python 3. For more information, see `Python 3 Support <http://docs.ansible.com/ansible/python_3_support.html>`_. | ||
* By default, Ansible uses the python interpreter located at :file:`/usr/bin/python` to run its | ||
modules. However, some Linux distributions may only have a Python 3 interpreter installed to | ||
:file:`/usr/bin/python3` by default. On those systems, you can either set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What error or behavior would the user see in this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Latest version adds the error to look out for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WRT issue #21594 this looks good.
Populate it with * virtualenv info (previously on the python3 support page) * BSD (Link to the working with BSD page) * Solaris (Document how to work around the non-POSIX shell on some Solaris hosts) Fixes ansible#21594
Fix for the module/plugin template unintentionally unindented inside of a raw block, leading to errors like: ERROR: docs/docsite/rst/modules/redshift_facts_module.rst:289:0: Explicit markup ends without a blank line; unexpected unindent.
345f298
to
b394a94
Compare
Merged to devel. Adding to the 2.5.x blocker project for potential inclusion in 2.5.2 |
* Update the documentation to list Python 3 as official * Add some reference targets for inventory variables so we can link to docs * Add a platform FAQ section Populate it with * virtualenv info (previously on the python3 support page) * BSD (Link to the working with BSD page) * Solaris (Document how to work around the non-POSIX shell on some Solaris hosts) Fixes #21594 * Fix some refs in the release_and_maintenance document * Fix unindent error in module template Fix for the module/plugin template unintentionally unindented inside of a raw block, leading to errors like: ERROR: docs/docsite/rst/modules/redshift_facts_module.rst:289:0: Explicit markup ends without a blank line; unexpected unindent. * Make wording for Solaris troubleshooting better. (cherry picked from commit a08459a)
cherry-picked to stable-2.5 for inclusion in 2.5.2 |
* Update the documentation to list Python 3 as official * Add some reference targets for inventory variables so we can link to docs * Add a platform FAQ section Populate it with * virtualenv info (previously on the python3 support page) * BSD (Link to the working with BSD page) * Solaris (Document how to work around the non-POSIX shell on some Solaris hosts) Fixes ansible#21594 * Fix some refs in the release_and_maintenance document * Fix unindent error in module template Fix for the module/plugin template unintentionally unindented inside of a raw block, leading to errors like: ERROR: docs/docsite/rst/modules/redshift_facts_module.rst:289:0: Explicit markup ends without a blank line; unexpected unindent. * Make wording for Solaris troubleshooting better.
SUMMARY
This rolls up
threefive docs changes:Explicit markup ends without a blank line;
errors that were introduced by the plugin template.ISSUE TYPE
ANSIBLE VERSION