Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_regedit: backport 2.5 stabilise tests #38918

Merged
merged 2 commits into from
Apr 17, 2018
Merged

win_regedit: backport 2.5 stabilise tests #38918

merged 2 commits into from
Apr 17, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

We should wait until the finalizer of the IDisposable objects are finished before trying to unload the registry hive. This should stop the issue where the handle is still being finalised when trying to unload the hive causing an access is denied exception.

Backport of #38912

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_regedit

ANSIBLE VERSION
2.5

@jborean93 jborean93 mentioned this pull request Apr 17, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Apr 17, 2018

cc @dagwieers @jhawkesworth @joshludwig @nitzmahone @smadam813
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Apr 17, 2018
@jborean93 jborean93 merged commit 10aa5a3 into ansible:stable-2.5 Apr 17, 2018
@jborean93 jborean93 deleted the win_regedit-test-stability-2.5 branch April 17, 2018 22:45
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 20, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @mkrizek