Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handle appending \n on stderr #39019

Merged
merged 2 commits into from Apr 23, 2018
Merged

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 19, 2018

SUMMARY

fixes #39007

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

inventory/script

ANSIBLE VERSION
2.5-2.6

@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Apr 19, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 19, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/inventory/script.py:110:26: E225 missing whitespace around operator

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 19, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 20, 2018
@jladdjr
Copy link
Contributor

jladdjr commented Apr 20, 2018

@bcoca - saw that this is going into devel. Is this being back-ported to 2.5.1 as well?

@bcoca bcoca merged commit 01e7f44 into ansible:devel Apr 23, 2018
@bcoca
Copy link
Member Author

bcoca commented Apr 23, 2018

@jladdjr 2.5.2 at earliest, 2.5.1 was already released

@thaumos
Copy link
Contributor

thaumos commented Apr 25, 2018

@bcoca has this been cherry-picked into stable-2.5?

@BR0kEN-
Copy link

BR0kEN- commented Apr 27, 2018

@bcoca Why is this not in 2.5.2?

@jladdjr
Copy link
Contributor

jladdjr commented Apr 27, 2018

@bcoca - I was also wondering the same thing. In case this hasn't been communicated, this is considered a breaking change to Tower and should be shipped ASAP.

@bcoca
Copy link
Member Author

bcoca commented Apr 27, 2018

because it was scheduled for next week initially and i had scheduled merging a bunch of backports for this Friday, the sudden change in release date meant I would not have time to do so. Expect it for 2.5.3

@nitzmahone nitzmahone added the tower_blocker Issues/pending fixes that are failing Tower integration tests or should otherwise block a release label Apr 27, 2018
@bcoca bcoca moved this from To Do to Done in 2.5.x blocker list Apr 27, 2018
jaywcarman added a commit to jaywcarman/power-up that referenced this pull request Jun 29, 2018
Ansible version '2.5.2' has a bug that will display "[ERROR]:" when
running a dynamic inventory script
(ansible/ansible#39007) due to an appended new
line character. This issue is resolved by
ansible/ansible#39019 which is included in
Ansible version '2.5.5'.
jaywcarman added a commit to IBM/power-up that referenced this pull request Jul 3, 2018
Ansible version '2.5.2' has a bug that will display "[ERROR]:" when
running a dynamic inventory script
(ansible/ansible#39007) due to an appended new
line character. This issue is resolved by
ansible/ansible#39019 which is included in
Ansible version '2.5.5'.
jaywcarman added a commit to jaywcarman/power-up that referenced this pull request Jul 3, 2018
Ansible version '2.5.2' has a bug that will display "[ERROR]:" when
running a dynamic inventory script
(ansible/ansible#39007) due to an appended new
line character. This issue is resolved by
ansible/ansible#39019 which is included in
Ansible version '2.5.5'.
jaywcarman added a commit to IBM/power-up that referenced this pull request Jul 3, 2018
Ansible version '2.5.2' has a bug that will display "[ERROR]:" when
running a dynamic inventory script
(ansible/ansible#39007) due to an appended new
line character. This issue is resolved by
ansible/ansible#39019 which is included in
Ansible version '2.5.5'.
rbrud pushed a commit to rbrud/power-up that referenced this pull request Jul 22, 2018
Ansible version '2.5.2' has a bug that will display "[ERROR]:" when
running a dynamic inventory script
(ansible/ansible#39007) due to an appended new
line character. This issue is resolved by
ansible/ansible#39019 which is included in
Ansible version '2.5.5'.
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. tower_blocker Issues/pending fixes that are failing Tower integration tests or should otherwise block a release
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Dynamic inventory errors in 2.5.1
7 participants