Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. … #39074

Merged
merged 2 commits into from
Apr 23, 2018
Merged

Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. … #39074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a22085
Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. …
Apr 20, 2018
014fd59
Fix all instances of self.config(self,...
Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ansible/module_utils/network/eos/eos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def load_config(self, commands, commit=False, replace=False):

if not all((bool(use_session), self.supports_sessions)):
if commit:
return self.configure(self, commands)
return self.configure(commands)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another place where this function is called. Would you mind fixing that also? https://github.com/eakman/ansible/blob/2a22085b2b4af6aa9de4b82311e9586d75611bb9/lib/ansible/module_utils/network/eos/eos.py#L423
Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll take a look!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I made the requested changes.

else:
self._module.warn("EOS can not check config without config session")
result = {'changed': True}
Expand Down Expand Up @@ -420,7 +420,7 @@ def load_config(self, config, commit=False, replace=False):

if not all((bool(use_session), self.supports_sessions)):
if commit:
return self.configure(self, config)
return self.configure(config)
else:
self._module.warn("EOS can not check config without config session")
result = {'changed': True}
Expand Down