Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return virtual_facts after VMWare platform detection #39149

Merged
merged 1 commit into from Apr 25, 2018
Merged

Return virtual_facts after VMWare platform detection #39149

merged 1 commit into from Apr 25, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

(cherry picked from commit 4f36d79)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/facts_vmware_detection.yaml
lib/ansible/module_utils/facts/virtual/linux.py

ANSIBLE VERSION
Stable-2.5

@Akasurde Akasurde requested a review from alikins April 23, 2018 10:07
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 23, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Apr 23, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 23, 2018
@Akasurde Akasurde changed the title Return virtual_facts after VMWare platform detection (#38237) Return virtual_facts after VMWare platform detection Apr 23, 2018
@Akasurde Akasurde mentioned this pull request Apr 23, 2018
Closed
@Akasurde
Copy link
Member Author

Closing and re-open for CI retrigger.

@Akasurde Akasurde closed this Apr 25, 2018
@Akasurde Akasurde reopened this Apr 25, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 25, 2018
@Akasurde Akasurde merged commit 7dbe964 into ansible:stable-2.5 Apr 25, 2018
@Akasurde Akasurde deleted the stable25-38237 branch April 25, 2018 12:24
@dagwieers dagwieers added the vmware VMware community label Feb 10, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alikins alikins Awaiting requested review from alikins

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Akasurde @dagwieers @ansibot @bmfp